Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set metadata and tagging unless explicitly defined #161

Closed
davidzhao opened this issue Oct 31, 2022 · 0 comments · Fixed by #162
Closed

Do not set metadata and tagging unless explicitly defined #161

davidzhao opened this issue Oct 31, 2022 · 0 comments · Fixed by #162

Comments

@davidzhao
Copy link
Member

#154 broke Digital Ocean spaces support since it doesn't support Tagging.

We should set these fields only when explicitly set by the user

{"level":"error","ts":1667131595.05049,"logger":"egress","caller":"pipeline/pipeline.go:654","msg":"could not upload file","nodeID":"NE_cX5epybD5hGE","egressID":"EG_8KS2fSFZtGDD","location":"S3","error":"InvalidArgument: \n\tstatus code: 400, request id: tx00000000000000f0f0477-00635e68cb-2914aa01-ams3c, host id: ","stacktrace":"[github.com/livekit/egress/pkg/pipeline.(*Pipeline).storeFile](http://github.com/livekit/egress/pkg/pipeline.(*Pipeline).storeFile)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes interaction with Digital Ocean S3 Implementation nkonev/egress
1 participant
@davidzhao