Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick to the pull host while triggering the catalyst pull start #2138

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Apr 18, 2024

Two changes:

  1. While resolving pull region, follow many redirects => Needed after the change with the GeoIP redirection mechanism
  2. Resolve also host and stick to that host => It will improve the number of timed out /pull requests, because when stream is pulled from a different region, but studio waits on another, then Mist Pull + Replication is to slow to satisfy 10s timeout on /pull

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:15am

@leszko leszko marked this pull request as ready for review April 18, 2024 12:11
@leszko leszko requested a review from a team as a code owner April 18, 2024 12:11
@emranemran
Copy link
Contributor

LGTM. One question: Shouldn't fetchWithTimeoutAndRedirects have been called even when we had the single redirect from CDN?

@leszko
Copy link
Contributor Author

leszko commented Apr 22, 2024

LGTM. One question: Shouldn't fetchWithTimeoutAndRedirects have been called even when we had the single redirect from CDN?

Now, we always use fetchWithTimeoutAndRedirects. Before, when we had 1 redirect, then I used fetchWithTimeout and checked the redirection URL, which worked as well.

@leszko leszko merged commit 29ad25a into master Apr 22, 2024
13 checks passed
@leszko leszko deleted the rafal/fix-resolve-pull-region branch April 22, 2024 08:02
leszko added a commit that referenced this pull request Apr 22, 2024
@leszko leszko restored the rafal/fix-resolve-pull-region branch April 22, 2024 09:47
leszko added a commit that referenced this pull request Apr 22, 2024
suhailkakar added a commit that referenced this pull request Apr 24, 2024
* Stick to the pull host while triggering the catalyst pull start (#2138)

* Revert "Stick to the pull host while triggering the catalyst pull start (#2138)" (#2141)

This reverts commit 29ad25a.

* Stick to the pull host while triggering the catalyst pull start (#2142)

* api: ingest: direct base & playback (#2139)

* api: ingest: direct base & playback

* fix

* fix

* implement for a specific hardcoded id for tests

* fix

* fix

* api: Handle active cleanup from pull lock API (#2144)

* refactor: improve api schema (#2109)

* format yaml

* add operationId to all endpoints

* marked rooms api as deprecated

* add tags to each endpoints

* moved unused components to db-schema

* add examples

* override name for sdk generation

* override operation name for sdk generatino

* run prettier & fix typo

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update api-schema.yaml

* fix: build error

* revert: add new-asset-from-url-payload to api-schema.yaml

* Update api-schema.yaml

* fix build issue

* hardcoded inputcreator filter

* fix: create stream and loosening schema (#2134)

* Update compile-schemas.js

* fix: tsconfig

* fix: revert additionalproperties

* fix: remove InputCreatorId unknown

* fix: api schema

* fix: api schema

* fix: revert changes to additional properties

* fix: fixes from review

* fix: lint

---------

Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Chase Adams <c@cadams.io>

* api: Query isHealthy field as a string to handle JSOnull (#2143)

* api: Query isHealthy field as a string to handle JSOnull

* api: Add check on boolean fields filter value

* api: moved objectStoreId and catalystPipelineStrategy to db schema (#2146)

* api: moved params to db schema

* Update db-schema.yaml

* remove url

* api: fix direct playback api (#2147)

* fix june trigger (#2145)

* fix sending track multiple times

* add missing imports

* replace track with page method

---------

Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: gioelecerati <50955448+gioelecerati@users.noreply.github.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Chase Adams <c@cadams.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants