Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix june trigger #2145

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix june trigger #2145

merged 3 commits into from
Apr 24, 2024

Conversation

suhailkakar
Copy link
Member

@suhailkakar suhailkakar commented Apr 22, 2024

What does this pull request do? Explain your changes. (required)
Preivously june events used to trigger multiple times, this PR adds callback to make sure each event is being sent just once

Specific updates (required)

  • Updated the implementation and used usedCallback hook

How did you test each of these updates (required)

  • Manually though browser network tab and June dashboard

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner April 22, 2024 22:05
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 1:52pm

Copy link
Member

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one question on the useEffect

packages/www/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
@suhailkakar suhailkakar merged commit 7e79dfa into master Apr 24, 2024
13 checks passed
@suhailkakar suhailkakar deleted the sk/june-trigger branch April 24, 2024 20:08
suhailkakar added a commit that referenced this pull request Apr 24, 2024
* Stick to the pull host while triggering the catalyst pull start (#2138)

* Revert "Stick to the pull host while triggering the catalyst pull start (#2138)" (#2141)

This reverts commit 29ad25a.

* Stick to the pull host while triggering the catalyst pull start (#2142)

* api: ingest: direct base & playback (#2139)

* api: ingest: direct base & playback

* fix

* fix

* implement for a specific hardcoded id for tests

* fix

* fix

* api: Handle active cleanup from pull lock API (#2144)

* refactor: improve api schema (#2109)

* format yaml

* add operationId to all endpoints

* marked rooms api as deprecated

* add tags to each endpoints

* moved unused components to db-schema

* add examples

* override name for sdk generation

* override operation name for sdk generatino

* run prettier & fix typo

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update packages/api/src/schema/api-schema.yaml

Co-authored-by: Victor Elias <victor@livepeer.org>

* Update api-schema.yaml

* fix: build error

* revert: add new-asset-from-url-payload to api-schema.yaml

* Update api-schema.yaml

* fix build issue

* hardcoded inputcreator filter

* fix: create stream and loosening schema (#2134)

* Update compile-schemas.js

* fix: tsconfig

* fix: revert additionalproperties

* fix: remove InputCreatorId unknown

* fix: api schema

* fix: api schema

* fix: revert changes to additional properties

* fix: fixes from review

* fix: lint

---------

Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Chase Adams <c@cadams.io>

* api: Query isHealthy field as a string to handle JSOnull (#2143)

* api: Query isHealthy field as a string to handle JSOnull

* api: Add check on boolean fields filter value

* api: moved objectStoreId and catalystPipelineStrategy to db schema (#2146)

* api: moved params to db schema

* Update db-schema.yaml

* remove url

* api: fix direct playback api (#2147)

* fix june trigger (#2145)

* fix sending track multiple times

* add missing imports

* replace track with page method

---------

Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: gioelecerati <50955448+gioelecerati@users.noreply.github.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
Co-authored-by: Chase Adams <c@cadams.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants