api: Query isHealthy field as a string to handle JSOnull #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
suhailkakar
approved these changes
Apr 23, 2024
suhailkakar
added a commit
that referenced
this pull request
Apr 24, 2024
* Stick to the pull host while triggering the catalyst pull start (#2138) * Revert "Stick to the pull host while triggering the catalyst pull start (#2138)" (#2141) This reverts commit 29ad25a. * Stick to the pull host while triggering the catalyst pull start (#2142) * api: ingest: direct base & playback (#2139) * api: ingest: direct base & playback * fix * fix * implement for a specific hardcoded id for tests * fix * fix * api: Handle active cleanup from pull lock API (#2144) * refactor: improve api schema (#2109) * format yaml * add operationId to all endpoints * marked rooms api as deprecated * add tags to each endpoints * moved unused components to db-schema * add examples * override name for sdk generation * override operation name for sdk generatino * run prettier & fix typo * Update packages/api/src/schema/api-schema.yaml Co-authored-by: Victor Elias <victor@livepeer.org> * Update packages/api/src/schema/api-schema.yaml Co-authored-by: Victor Elias <victor@livepeer.org> * Update packages/api/src/schema/api-schema.yaml Co-authored-by: Victor Elias <victor@livepeer.org> * Update api-schema.yaml * fix: build error * revert: add new-asset-from-url-payload to api-schema.yaml * Update api-schema.yaml * fix build issue * hardcoded inputcreator filter * fix: create stream and loosening schema (#2134) * Update compile-schemas.js * fix: tsconfig * fix: revert additionalproperties * fix: remove InputCreatorId unknown * fix: api schema * fix: api schema * fix: revert changes to additional properties * fix: fixes from review * fix: lint --------- Co-authored-by: Victor Elias <victor@livepeer.org> Co-authored-by: Chase Adams <c@cadams.io> * api: Query isHealthy field as a string to handle JSOnull (#2143) * api: Query isHealthy field as a string to handle JSOnull * api: Add check on boolean fields filter value * api: moved objectStoreId and catalystPipelineStrategy to db schema (#2146) * api: moved params to db schema * Update db-schema.yaml * remove url * api: fix direct playback api (#2147) * fix june trigger (#2145) * fix sending track multiple times * add missing imports * replace track with page method --------- Co-authored-by: Rafał Leszko <rafal@livepeer.org> Co-authored-by: gioelecerati <50955448+gioelecerati@users.noreply.github.com> Co-authored-by: Victor Elias <victor@livepeer.org> Co-authored-by: Chase Adams <c@cadams.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This fixes the
isHealthyfilter on streams list so we don't get this error:cannot cast jsonb null to type booleanThis happened not when the field was not set, in which case
data->'isHealthy'returnsa SQL
NULLbut when the field was actually set to a JSONnullvalue, which issometimes done here.
Postgres supports converting
NULLto boolean, but notjsonb nullto boolean, whichis when the query exploded. This fixes it by querying the field as
TEXT(->>) instead,which automatically converts
jsonb nullto a SQLNULLas well and everything works.Also added a little validation that was missing in
parseFilters.Specific updates (required)
isHealthyfield query to->>instead of->parseFiltersHow did you test each of these updates (required)
Ran queries on Postgres DB.
Does this pull request close any open issues?
https://discord.com/channels/423160867534929930/611650333243867170/1231996105433157632
Checklist