feat: supports “prerelease” versions #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xufulin1994
added
the
change/standard
|
This change is |
yanan-xu
reviewed
Mar 25, 2024
src/grammar/base.pegjs
Outdated
| @@ -35,7 +35,7 @@ description = "\"" _ inner:(!"\"" i:. {return i})* "\"" { | |||
| } | |||
|
|
|||
| // version | |||
| semver = semver:([0-9]+ "." [0-9]+ "." [0-9]+) { return semver.flat().join(""); } | |||
| semver = semver:([0-9]+ "." [0-9]+ "." [0-9]+ ("-" [a-zA-Z0-9.-]+)?) { return semver.flat().flat().join(""); } | |||
There was a problem hiding this comment.
what a ugly flat here.
The flat() method of Array can specific a depth as you want.
flat(2), flat(Infinity)
|
And please take a test on the api-specs to see if the config/*.json are working well with this format of version definition. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The VMA app uses the python semver package that supports “prerelease” versions, as well as the usual Major.Minor.Patch. The semver format goes something like Major.Minor.Patch[-prerelease_id.#] where prerelease_id is a text string - for us it’s “dev” for all of the intermediate versions we build and deploy to our DEV environment and “hotfix” for any intermediate versions that we might need to create in our PROD environment because our DEV environment has diverged too far from PROD.