Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you have a view that is alphabetically before 'All', iJenkins loads in a weird state #42

Closed
colons opened this issue Jun 28, 2015 · 5 comments

Comments

@colons
Copy link

colons commented Jun 28, 2015

We have a view on our Jenkins server with a name that appears alphabetically before 'All'. When iJenkins first loads up, it claims (in the top right corner) to be showing this custom view, but all builds are visible in the list, and the pie chart at the top refers to all builds. While all builds are visible, however, only the builds in the view get fully populated, the rest remain in this weird half-loaded limbo.

@tammojan
Copy link
Contributor

Ah that would explain the crippled view I always see (since every build starts with an underscore).

@rafiki270
Copy link
Collaborator

Unfortunately I won't be in a position to fix this at least for the next month and a half ... If anyone could pick this up that would great otherwise I will fix this later ...

Sent from my awesome iPhone

On 28 Jun 2015, at 11:30, Tammo Jan Dijkema notifications@github.com wrote:

Ah that would explain the crippled view I always see (since every build starts with an underscore).


Reply to this email directly or view it on GitHub.

@tammojan
Copy link
Contributor

tammojan commented Jun 28, 2015 via email

@rafiki270
Copy link
Collaborator

Just a thought but do you have an idea how this will behave in a multilingual environment?

Sent from my awesome iPhone

On 28 Jun 2015, at 15:46, Tammo Jan Dijkema notifications@github.com wrote:

I'll grep the code for "All" and see if a fix is trivial.

Reply to this email directly or view it on GitHub.

@tammojan
Copy link
Contributor

The cause is probably in the following lines in FTServerHomeViewController.m:91 , which selects the first view as a default (and the rest of the logic initializes everything assuming this is 'All'):

if (_serverObject.views.count > 1) {
    if (!_selectedView) {
        _selectedView = [_views objectAtIndex:0];
    }
}

A solution would be to check if there is a view named 'All' (or any translation).

tammojan added a commit to tammojan/iJenkins that referenced this issue Jun 28, 2015
…ich usually is 'All' but not always). Fixes issue LiveUI#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants