Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: devcontainer #332

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Feature: devcontainer #332

merged 6 commits into from
Feb 26, 2024

Conversation

geminixiang
Copy link
Contributor

@geminixiang geminixiang commented Feb 26, 2024

Impl

1. devcontainer

environment

  • default shell: zsh (oh-my-zsh)
  • dependency: ffmpeg, graphviz, python 3.10, curl, git
  • Python
    • poetry virtual environment (default path: .venv under project folder.)
    • pre-commit hooks
  • VSCode
    • extension
      • ms-python.python
      • ms-python.vscode-pylance
      • GitHub.copilot
      • mypy-type-checker

2. unittest

devcontainer exec poetry run pytest ./src --snapshot-update

@geminixiang
Copy link
Contributor Author

mypy 註解是由 chatgpt 寫的,我得花點時間確認一下文件

@lucemia
Copy link
Contributor

lucemia commented Feb 26, 2024

mypy 註解是由 chatgpt 寫的,我得花點時間確認一下文件

現在 main 是不過的,所以能另開 issue 處理的就先另開吧

@geminixiang
Copy link
Contributor Author

關於 mypy config 已經 cherry-pick 到 #334

@geminixiang geminixiang marked this pull request as ready for review February 26, 2024 07:16
Copy link
Contributor

@lucemia lucemia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

測試過後 OK 感謝

@lucemia lucemia merged commit c85f717 into main Feb 26, 2024
10 checks passed
@lucemia lucemia deleted the feature/devcontainer branch February 26, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants