Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy config #334

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Update mypy config #334

merged 6 commits into from
Mar 4, 2024

Conversation

geminixiang
Copy link
Contributor

@geminixiang geminixiang commented Feb 26, 2024

整合 mypy config 進 pyproject.toml

  1. synchronize the mypy settings between .pre-commit-config.yaml and pyproject.toml
  2. pre-commit using mypy config file from pyproject.toml
  3. check extension: Mypy Type Checker is work!

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (903c488) to head (b1b77a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          24       24           
  Lines         753      753           
=======================================
  Hits          730      730           
  Misses         23       23           
Flag Coverage Δ
$3.10 96.94% <ø> (ø)
$3.11 96.94% <ø> (ø)
$3.12 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geminixiang

This comment was marked as outdated.

@geminixiang
Copy link
Contributor Author

pre-commit 加了個 --config-file 有確保是吃到 pyproject.toml

mypy . == pre-commit run mypy -a == extension Mypy Type Chekcer

@geminixiang geminixiang marked this pull request as ready for review February 29, 2024 02:37
@lucemia
Copy link
Contributor

lucemia commented Mar 4, 2024

@geminixiang 需要 Review 嗎?

@geminixiang
Copy link
Contributor Author

@geminixiang 需要 Review 嗎?

需要!麻煩了

@lucemia
Copy link
Contributor

lucemia commented Mar 4, 2024

是不是沒有辦法 Request 我 Review?

@lucemia lucemia merged commit 9d8db21 into main Mar 4, 2024
7 checks passed
@lucemia lucemia deleted the mypy-config branch March 4, 2024 14:35
@geminixiang
Copy link
Contributor Author

是不是沒有辦法 Request 我 Review?

我看右上角是已經選定 reviewer 了
以為已經 request reviewer 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants