/linux_media

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

TBS-6922 - Support for? #15

Closed
jonathanmbradshaw opened this Issue Feb 25, 2014 · 39 comments

Comments

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
6 participants
@jonathanmbradshaw @ljalves @crazycat69 @megavega @Alfredo- @sveba
@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

Guys, a short note of thanks for the OpenSource TBS drivers!

I have a 6922, can you tell me if this device is supported in the current code base, if not is practical to support the TBS 6922 in the future?

Once again my thanks for your work and of the O/S TBS Drivers! - jmb

[ 13.894585] DVB: registering new adapter (SAA716x dvb adapter)
[ 14.644669] TurboSight TBS6922 DVB-S2 card MAC=00:22🆎e0:3b:fb
@ljalves
Owner

ljalves commented Feb 25, 2014

Can you please post the reference of the 'big' chip on the card?
@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

AV2011 TAS2100 SAA7160ET

The big chip is TSA...

This info is from tbsdtv at http://www.tbsdtv.com/blog/comparison-of-tbs6920-tbs6921-tbs6922.html, I will pull the cover this evening and let you know if I find any different when I inspect the card.

As expected the Big Chip is TAS 2100-CL100
@ljalves
Owner

ljalves commented Feb 25, 2014

Then it should be easy do add.
Please paste here the output of 'lspci -v | grep -i saa'
@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

lspci -v | grep -i saa

02:00.0 Multimedia controller: Philips Semiconductors SAA7160 (rev 03)
Kernel driver in use: SAA716x TBS
@ljalves
Owner

ljalves commented Feb 25, 2014

Hi,
Just added the TBS6922 card.
Please test and report if it works.

Regards
@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

I'll load and test this evening..

On Tue, Feb 25, 2014 at 5:46 PM, Luis Alves notifications@github.comwrote:

Hi,
Just added the TBS6922 card.
Please test and report if it works.

Regards

Reply to this email directly or view it on GitHubhttps://github.com/ljalves/linux_media/issues/15#issuecomment-36036236
.
@crazycat69
Contributor

crazycat69 commented Feb 25, 2014

I check with Technotrend S2-4100 (ODM TBS6922).
Fixed I2Cbus num and LNB pwr ctl.
crazycat69/linux_media@99cfa63

Tuner/demod attached ok, LNB power and 22KHz ctl is ok, but no lock.
@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

Following is the output from the test (DMESG), it looks like the card did not start.. if you need further info/actions etc.. please let me know, happy to do what I can to help.. jmb

sudo modprobe saa716x_budget int_type=1

modprobe: ERROR: could not insert 'saa716x_budget': Unknown symbol in module,
or unknown parameter (see dmesg)

dmesg

: 
:

[ 181.536331] WARNING: You are using an experimental version of the media stack.
As the driver is backported to an older kernel, it doesn't offer
enough quality for its usage in production.
Use it with care.
Latest git patches (needed if you report a bug to linux-media@vger.kernel.org):
c6d9865 TBS6922: Added card - needs testing. Register init sequence is different in original drivers so it might need to be changed if it doesn't work.
[ 181.544044] tas2101: Unknown symbol i2c_del_mux_adapter (err 0)
[ 181.544079] tas2101: Unknown symbol i2c_add_mux_adapter (err 0)
:
:

jonathanmbradshaw closed this Feb 25, 2014

@jonathanmbradshaw

jonathanmbradshaw commented Feb 25, 2014

Sorry, issue should be open, closed in err

jonathanmbradshaw reopened this Feb 25, 2014

@ljalves
Owner

ljalves commented Feb 25, 2014

jonathanmbradshaw,
What kernel version are you using?
That issue is easy to solve, but since CrazyCat added the auto kernel dependency for the i2c_mux it should be working...

Can you update to a 'recent' kernel? What linux distro are you using?
@ljalves
Owner

ljalves commented Feb 25, 2014

CrazyCat,

You're saying that the Technotrend S2-4100 is equal to the TBS6922?

The chips are a bit different from the TBS6982 (demod TAS2100 vs TAS2101 and tuner AV2011 vs AV2012)

Please try to change this:
https://github.com/ljalves/linux_media/blob/latest/drivers/media/pci/saa716x/saa716x_budget.c#L940

The tuner ID should be AV2011 (and not AV2012).

Edit:
Just commited the change: e8507dc
Test and report.

If it still doesn't work, I can code the init reg table for the TAS2100 (which I already confirm that is different from the TAS2101).
@crazycat69
Contributor

crazycat69 commented Feb 26, 2014

TT S2-4100 = TBS 6922. Tuner AV2011, Demod TAS 2100.
Now available TBS 6922SE with AV2012/TAS2101 (same price).
Windows and Linux drivers for 6922 and 6922SE is same.
@jonathanmbradshaw

jonathanmbradshaw commented Feb 27, 2014

Guy's thanks for all the help so far..

Following a Kernel update to 3.13.4-200.fc20.x86_64 (Fedora 20) things do not seem to have improved. Happy to provide any additional info that might help..

dmesg (following an install and reboot)
:
[ 12.497520] dvb_core: module verification failed: signature and/or required key missing - tainting kernel
[ 12.498533] WARNING: You are using an experimental version of the media stack.
As the driver is backported to an older kernel, it doesn't offer
enough quality for its usage in production.
Use it with care.
Latest git patches (needed if you report a bug to linux-media@vger.kernel.org):
5c665e0 tas2101: Extend modcodes with 16/32APS.
:
[ 12.930586] tas2101: Unknown symbol i2c_del_mux_adapter (err 0)
[ 12.930599] tas2101: Unknown symbol i2c_add_mux_adapter (err 0)
:
[ 13.361774] WARNING: You are using an experimental version of the media stack.
As the driver is backported to an older kernel, it doesn't offer
enough quality for its usage in production.
Use it with care.
Latest git patches (needed if you report a bug to linux-media@vger.kernel.org):
5c665e0 tas2101: Extend modcodes with 16/32APS.
:
@crazycat69
Contributor

crazycat69 commented Feb 27, 2014

compiled with media_build ? look like kernel compiled without I2C mux bus support.
@jonathanmbradshaw

jonathanmbradshaw commented Feb 27, 2014

As far as I can tell the build has been done following the instructions at https://github.com/ljalves/linux_media/wiki/Installating,-Upgrading-and-Tvheadend

I did observe the following during the most recent build.. perhaps it is relevant

Building modules, stage 2.
MODPOST 582 modules
WARNING: "i2c_add_mux_adapter" [/home/jmb/TVdriver/Pass-3/media_build/v4l/tas2101.ko] undefined!
WARNING: "i2c_del_mux_adapter" [/home/jmb/TVdriver/Pass-3/media_build/v4l/tas2101.ko] undefined!
@ljalves
Owner

ljalves commented Feb 27, 2014

Did you made a "make distclean" before compiling, after upgrading your kernel?

Try removing the media_build and start from scratch...
@jonathanmbradshaw

jonathanmbradshaw commented Feb 27, 2014

git clone git://linuxtv.org/media_build.git
git clone --depth=1 https://github.com/ljalves/linux_media.git -b latest ./media
cd media_build
make dir DIR=../media
make distclean
make
sudo make install
sudo make rmmod
sudo modprobe saa716x_budget int_type=1

As requested, started from scratch but the same result..
@jonathanmbradshaw

jonathanmbradshaw commented Mar 3, 2014

Just keeping the LiteOn here,,

Over the weekend I ran the new media_build/media repo's into a 'from DVD' Fedora-20 build with the same result. The original platform (Fedora-18 upgraded [FEDUP] to Fedora-20 @ Linux version 3.13.5-200.fc20.x86_64.) is just the same - no change.

B/R jmb
@megavega

megavega commented Mar 14, 2014

Hi! I got TBS 6922SE with AV2012/TAS2101 chips and i can't make it work in any program in Linux with tbs driver. In Windows board works fine with last driver from tbs. In Linux tuner can show signal level but can't receive any data like in this post #12 . Your driver can't detect any device. I try Ubuntu 12.04 and 13.10. Guys from TBS ignore problem, says what In Windows it works then all is ok. Please add this board to your driver i can't use windows.
@Alfredo-

Alfredo- commented Mar 20, 2014

Hi

There is a way to activate a debug?.
Not working on my pc these drivers. OpenSuse 13.1 64bit

Regards

FSSDawid referenced this issue Apr 11, 2014

Closed

WARNING: "i2c_add_mux_adapter" [/mnt/cache/dvb_drivers/media_build/v4l/tas2101.ko] undefined! #21

@sveba

sveba commented May 9, 2014

Compiled today with kernel 3.13.0-24-generic on Ubuntu 14.04.
TBS 6922 cannot find any channels:

w_scan -fs -s S19E2 -c DE -X > channels.conf
w_scan version 20130331 (compiled for DVB API 5.10)
using settings for 19.2 east Astra 1F/1G/1H/1KR/1L
scan type SATELLITE, channellist 67
output format czap/tzap/szap/xine
output charset 'UTF-8', use -C <charset> to override
Info: using DVB adapter auto detection.
        /dev/dvb/adapter0/frontend0 -> SATELLITE "Tmax TAS2101": very good :-))

Using SATELLITE frontend (adapter /dev/dvb/adapter0/frontend0)
-_-_-_-_ Getting frontend capabilities-_-_-_-_
Using DVB API 5.a
frontend 'Tmax TAS2101' supports
INVERSION_AUTO
DVB-S
DVB-S2
FREQ (0.95GHz ... 2.15GHz)
SRATE (1.000MSym/s ... 45.000MSym/s)
using LNB "UNIVERSAL"

... at the end

trying 'S  f = 12722 kHz H SR = 22000  5/6 0,35  QPSK'
(time: 04:50)
trying 'S  f = 12729 kHz V SR = 22000  5/6 0,35  QPSK'
(time: 04:53)

ERROR: Sorry - i couldn't get any working frequency/transponder
 Nothing to scan!!

Closed source driver is working :(
@megavega

megavega commented May 27, 2014

sveba! How do you compile TBS drivers in U14.04 ? Can u share a list of commands? I have some errors all time. Thanks!
@Alfredo-

Alfredo- commented Jun 13, 2014 

Hi
I did the following:
alfredo@linux-lfzk:~> scan -a 0 -n Arsat > sat.conf
scanning Arsat
using '/dev/dvb/adapter0/frontend0' and '/dev/dvb/adapter0/demux0'
initial transponder 11955000 V 2149000 3
initial transponder 12020000 V 30000000 5
>>> tune to: 11955:v:0:2149
DVB-S IF freq is 1355000
WARNING: >>> tuning failed!!!
>>> tune to: 11955:v:0:2149 (tuning failed)
DVB-S IF freq is 1355000
WARNING: >>> tuning failed!!!
>>> tune to: 12020:v:0:30000
DVB-S IF freq is 1420000
WARNING: filter timeout pid 0x0011
WARNING: filter timeout pid 0x0010
WARNING: filter timeout pid 0x0010
dumping lists (27 services)
Done.
Arsat:
# AMC 6 @ 72W
# freq pol sr fec
# Canal 9 Litoral
S 11955000 V 02149000 3/4
# C7, Acua, Tecnópolis, Encuentro, INCA
S 12020000 V 30000000 5/6

And I get:
sat.conf:

{0001}:12020✌️0:30000:272:52:1
{0002}:12020✌️0:30000:288:34:2
{0003}:12020✌️0:30000:304:40:3
{0004}:12020✌️0:30000:320:53:4
{0005}:12020✌️0:30000:43:45:5
{0007}:12020✌️0:30000:368:56:7
{0008}:12020✌️0:30000:384:57:8
{0009}:12020✌️0:30000:400:58:9
{000a}:12020✌️0:30000:416:59:10
{000c}:12020✌️0:30000:448:449:12
{000d}:12020✌️0:30000:464:465:13
{000e}:12020✌️0:30000:480:481:14
{000f}:12020✌️0:30000:496:497:15
{0010}:12020✌️0:30000:77:68:16
{0011}:12020✌️0:30000:144:145:17
{0012}:12020✌️0:30000:81:37:18
{0016}:12020✌️0:30000:70:71:22
{0017}:12020✌️0:30000:72:73:23
{0018}:12020✌️0:30000:74:75:24
{0019}:12020✌️0:30000:49:35:25
{001e}:12020✌️0:30000:1872:1873:30
{0033}:12020✌️0:30000:1296:60:51
{0035}:12020✌️0:30000:85:83:53
{007f}:12020✌️0:30000:1792:1817:127
{03d5}:12020✌️0:30000:0:387:981
{0ffd}:12020✌️0:30000:0:0:4093
{0ffe}:12020✌️0:30000:0:0:4094

{ is [ and } is ]
channel list TP12020: http://www.portaleds.com/espanol/tps.php?sat=2880&fre=12020V

Channels with other frequencies not detected

but I can't see any channel with VLC
@crazycat69
Contributor

crazycat69 commented Jun 13, 2014

Look like TBS 6922 and TT S2-4100 noT work. Maybe 6922SE work.

TBS6982 work ok.
@Alfredo-

Alfredo- commented Jun 13, 2014

Hello

What program do you use to watch TV and like you do?

Kaffeine shows occasionally a picture or sound. Usually the screen is gray or green and with some pixelation. But find the channels on this TP.

I have TBS6922 (the old card)

thanks
@Alfredo-

Alfredo- commented Jun 13, 2014

Hi
In the photo you can see a screenshot of a television channel.
At the top is the logo of the channel that is in blue and white.

Regards
tbs6922
@ljalves
Owner

ljalves commented Jun 13, 2014

Hi Alfredo,
That looks that you might have a weak signal or wrong TP settings (like wrong symbol rate).
@Alfredo-

Alfredo- commented Jun 14, 2014

Thanks for your answer and work.

The TP and SR are correct.

Arrived at this result by chance (accident).
I tested with 2 satellites and their TP; just tuned this TP.

I have no experience, but it could be that this getting bad intermediate frequency or some initialization parameter.
Or when I compiling it gave many lines of warning. Perhaps failure is here

Some of them:

/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_pci.c:20:20: warning: 'saa716x_msi_handler' defined but not used [-Wunused-function]
static irqreturn_t saa716x_msi_handler(int irq, void *dev_id)
^
In file included from /home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_rom.c:7:0:
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_rom.c: In function 'saa716x_eeprom_header':
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_rom.c:117:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
sizeof (struct saa716x_romhdr),
^
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_priv.h:39:72: note: in definition of macro 'dprintk'
printk(KERN_ERR "%s (%d): " fmt "\n" , __func , SAA716x_DEV , ##arg);
^
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_rom.c:117:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
sizeof (struct saa716x_romhdr),
^
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_priv.h:41:75: note: in definition of macro 'dprintk'
printk(KERN_NOTICE "%s (%d): " __fmt "\n" , __func , SAA716x_DEV , ##__arg);
^
/home/alfredo/TBS6922/git-11-06-2014/media_build/v4l/saa716x_rom.c:117:19: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
sizeof (struct saa716x_romhdr), ...

Thanks, again
@Alfredo-

Alfredo- commented Jun 14, 2014

Hi Luis

I expand a bit: I've tried other satellites and some can "tune" some TP, but not all.
In all cases the image is like the one I presented. In some cases he could find the provider and programming.
All I have used TP, I watch perfectly with the proprietary driver.

How you get initialization of integrated circuit TAS2101? Which card?
I ask because I spend with another TV card, the one I had was a little different initialization which had used the developer and this was the problem, and this case is very similar.

VLC gives the following:

ts debug: transport_error_indicator set (pid=593)
ts warning: first packet for pid=594 cc=0x2
ts debug: transport_error_indicator set (pid=593)
ts warning: discontinuity received 0x9 instead of 0x8 (pid=593)
ts debug: transport_error_indicator set (pid=593)
ts warning: discontinuity received 0xb instead of 0xa (pid=593)
ts warning: discontinuity received 0xe instead of 0xd (pid=593)
ts debug: transport_error_indicator set (pid=594)
ts debug: transport_error_indicator set (pid=593)
ts warning: discontinuity received 0x6 instead of 0xf (pid=593)
ts warning: scrambled state changed on pid 593 (0->1)
ts warning: discontinuity received 0x5 instead of 0x7 (pid=593)
ts warning: scrambled state changed on pid 593 (1->0)
ts warning: discontinuity received 0x7 instead of 0x6 (pid=593)

Gracias, obrigado, thanks.
@Alfredo-

Alfredo- commented Jun 19, 2014

Hi all

I think that what follows shows the problem with the driver to work.
The TP's 11528000, 11560000, 11600000, 11640000 and 11670000 channel takes TP 11520.
It's like failing to recognize the frequency that has to work.

Regards

alfredo@linux-lfzk:~> scan -a 0 -n TupacKatari > tupac.conf
scanning TupacKatari
using '/dev/dvb/adapter0/frontend0' and '/dev/dvb/adapter0/demux0'
initial transponder 11480000 H 15000000 3
initial transponder 11480000 V 15000000 3
initial transponder 11520000 V 30000000 3
initial transponder 11528000 V 30000000 3
initial transponder 11560000 V 30000000 3
initial transponder 11600000 V 30000000 3
initial transponder 11640000 V 30000000 3
initial transponder 11670000 V 30000000 3

tune to: 11480:h:0:15000
DVB-S IF freq is 1730000
WARNING: >>> tuning failed!!!
tune to: 11480:h:0:15000 (tuning failed)
DVB-S IF freq is 1730000
WARNING: >>> tuning failed!!!
tune to: 11480✌️0:15000
DVB-S IF freq is 1730000
WARNING: >>> tuning failed!!!
tune to: 11480✌️0:15000 (tuning failed)
DVB-S IF freq is 1730000
WARNING: >>> tuning failed!!!
tune to: 11520✌️0:30000
DVB-S IF freq is 1770000
Network Name 'Site - 1'
0x0000 0x0013: pmt_pid 0x005b Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0043 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0044 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0023 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0052 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0061 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0027 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x004b Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0020 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x003e Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0053 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x005c Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0036 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x003a Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x006d Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0031 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0072 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0051 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x005a Harmonic -- Reality TV (running)
WARNING: filter timeout pid 0x0010
tune to: 11528✌️0:30000
DVB-S IF freq is 1778000
Network Name 'Site - 1'
0x0000 0x0013: pmt_pid 0x005b Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0043 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0044 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0023 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0052 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0061 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0027 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x004b Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0020 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x003e Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0053 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x005c Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0036 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x003a Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x006d Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0031 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0072 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0051 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x005a Harmonic -- Reality TV (running)
WARNING: filter timeout pid 0x0010
tune to: 11560✌️0:30000
DVB-S IF freq is 1810000
0x0000 0x0013: pmt_pid 0x0000 Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0000 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0000 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0000 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0000 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0000 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0000 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x0000 Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0000 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x0000 Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0000 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x0000 Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0000 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x0000 Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x0000 Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0000 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0000 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0000 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x0000 Harmonic -- Reality TV (running)
Network Name 'Site - 1'
WARNING: filter timeout pid 0x0010
tune to: 11600✌️0:30000
DVB-S IF freq is 1850000
Network Name 'Site - 1'
0x0000 0x0013: pmt_pid 0x005b Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0043 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0044 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0023 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0052 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0061 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0027 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x004b Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0020 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x003e Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0053 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x005c Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0036 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x003a Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x006d Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0031 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0072 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0051 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x005a Harmonic -- Reality TV (running)
WARNING: filter timeout pid 0x0010
tune to: 11640✌️0:30000
DVB-S IF freq is 1890000
Network Name 'Site - 1'
0x0000 0x0013: pmt_pid 0x005b Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0043 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0044 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0023 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0052 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0061 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0027 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x004b Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0020 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x003e Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0053 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x005c Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0036 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x003a Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x006d Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0031 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0072 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0051 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x005a Harmonic -- Reality TV (running)
WARNING: filter timeout pid 0x0010
tune to: 11670✌️0:30000
DVB-S IF freq is 1920000
Network Name 'Site - 1'
0x0000 0x0013: pmt_pid 0x0000 Harmonic -- NICK JR (running)
0x0000 0x0014: pmt_pid 0x0000 Harmonic -- De Pelicula (running)
0x0000 0x0020: pmt_pid 0x0000 Harmonic -- Golden (running)
0x0000 0x0021: pmt_pid 0x0000 Harmonic -- GoldenEdge (running)
0x0000 0x0022: pmt_pid 0x0000 Harmonic -- Film Arts (running)
0x0000 0x0027: pmt_pid 0x0000 Harmonic -- Comedy Central (running)
0x0000 0x0032: pmt_pid 0x0000 Harmonic -- Gourmet (running)
0x0000 0x0034: pmt_pid 0x0000 Harmonic -- Casa Club (running)
0x0000 0x0036: pmt_pid 0x0000 Harmonic -- Canal De Las Estrellas (running)
0x0000 0x0037: pmt_pid 0x0000 Harmonic -- Tv Novelas (running)
0x0000 0x0047: pmt_pid 0x0000 Harmonic -- MTV (running)
0x0000 0x0049: pmt_pid 0x0000 Harmonic -- VH-1 (running)
0x0000 0x004b: pmt_pid 0x0000 Harmonic -- RitmoSon (running)
0x0000 0x004c: pmt_pid 0x0000 Harmonic -- Telehit (running)
0x0000 0x0051: pmt_pid 0x0000 Harmonic -- History HD (running)
0x0000 0x005d: pmt_pid 0x0000 Harmonic -- Distrio Comedia (running)
0x0000 0x0069: pmt_pid 0x0000 Harmonic -- WB HD (running)
0x0000 0x006f: pmt_pid 0x0000 Harmonic -- Cosmo LA (running)
0x0000 0x0070: pmt_pid 0x0000 Harmonic -- Reality TV (running)
WARNING: filter timeout pid 0x0010
tune to: 1160✌️0:30000
DVB-S IF freq is 8590000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1160✌️0:30000
DVB-S IF freq is 8590000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1130✌️0:60000
DVB-S IF freq is 8620000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1130✌️0:60000
DVB-S IF freq is 8620000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1010✌️0:60000
DVB-S IF freq is 8740000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1010✌️0:60000
DVB-S IF freq is 8740000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 0✌️0:60000
DVB-S IF freq is 9750000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 0✌️0:60000
DVB-S IF freq is 9750000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1050✌️0:60000
DVB-S IF freq is 8700000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
tune to: 1050✌️0:60000
DVB-S IF freq is 8700000
__tune_to_transponder:1910: ERROR: Setting frontend parameters failed: 22 Invalid argument
dumping lists (114 services)
Done.

dmesg:

[ 4617.222542] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8590000 out of range (950000..2150000)
[ 4617.484032] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8590000 out of range (950000..2150000)
[ 4617.747067] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8620000 out of range (950000..2150000)
[ 4618.009852] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8620000 out of range (950000..2150000)
[ 4618.272646] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8740000 out of range (950000..2150000)
[ 4618.535427] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8740000 out of range (950000..2150000)
[ 4618.798213] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 9750000 out of range (950000..2150000)
[ 4619.061006] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 9750000 out of range (950000..2150000)
[ 4619.323651] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8700000 out of range (950000..2150000)
[ 4619.586589] SAA716x Budget 0000:02:00.0: DVB: adapter 0 frontend 0 frequency 8700000 out of range (950000..2150000)

@ljalves ljalves pushed a commit that referenced this issue Jun 23, 2014

Dmitry Kasatkin + Mimi Zohar ima: introduce ima_kernel_read() 
Commit 8aac627 "move exit_task_namespaces() outside of exit_notify"
introduced the kernel opps since the kernel v3.10, which happens when
Apparmor and IMA-appraisal are enabled at the same time.

----------------------------------------------------------------------
[  106.750167] BUG: unable to handle kernel NULL pointer dereference at
0000000000000018
[  106.750221] IP: [<ffffffff811ec7da>] our_mnt+0x1a/0x30
[  106.750241] PGD 0
[  106.750254] Oops: 0000 [#1] SMP
[  106.750272] Modules linked in: cuse parport_pc ppdev bnep rfcomm
bluetooth rpcsec_gss_krb5 nfsd auth_rpcgss nfs_acl nfs lockd sunrpc
fscache dm_crypt intel_rapl x86_pkg_temp_thermal intel_powerclamp
kvm_intel snd_hda_codec_hdmi kvm crct10dif_pclmul crc32_pclmul
ghash_clmulni_intel aesni_intel aes_x86_64 glue_helper lrw gf128mul
ablk_helper cryptd snd_hda_codec_realtek dcdbas snd_hda_intel
snd_hda_codec snd_hwdep snd_pcm snd_page_alloc snd_seq_midi
snd_seq_midi_event snd_rawmidi psmouse snd_seq microcode serio_raw
snd_timer snd_seq_device snd soundcore video lpc_ich coretemp mac_hid lp
parport mei_me mei nbd hid_generic e1000e usbhid ahci ptp hid libahci
pps_core
[  106.750658] CPU: 6 PID: 1394 Comm: mysqld Not tainted 3.13.0-rc7-kds+ #15
[  106.750673] Hardware name: Dell Inc. OptiPlex 9010/0M9KCM, BIOS A08
09/19/2012
[  106.750689] task: ffff8800de804920 ti: ffff880400fca000 task.ti:
ffff880400fca000
[  106.750704] RIP: 0010:[<ffffffff811ec7da>]  [<ffffffff811ec7da>]
our_mnt+0x1a/0x30
[  106.750725] RSP: 0018:ffff880400fcba60  EFLAGS: 00010286
[  106.750738] RAX: 0000000000000000 RBX: 0000000000000100 RCX:
ffff8800d51523e7
[  106.750764] RDX: ffffffffffffffea RSI: ffff880400fcba34 RDI:
ffff880402d20020
[  106.750791] RBP: ffff880400fcbae0 R08: 0000000000000000 R09:
0000000000000001
[  106.750817] R10: 0000000000000000 R11: 0000000000000001 R12:
ffff8800d5152300
[  106.750844] R13: ffff8803eb8df510 R14: ffff880400fcbb28 R15:
ffff8800d51523e7
[  106.750871] FS:  0000000000000000(0000) GS:ffff88040d200000(0000)
knlGS:0000000000000000
[  106.750910] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  106.750935] CR2: 0000000000000018 CR3: 0000000001c0e000 CR4:
00000000001407e0
[  106.750962] Stack:
[  106.750981]  ffffffff813434eb ffff880400fcbb20 ffff880400fcbb18
0000000000000000
[  106.751037]  ffff8800de804920 ffffffff8101b9b9 0001800000000000
0000000000000100
[  106.751093]  0000010000000000 0000000000000002 000000000000000e
ffff8803eb8df500
[  106.751149] Call Trace:
[  106.751172]  [<ffffffff813434eb>] ? aa_path_name+0x2ab/0x430
[  106.751199]  [<ffffffff8101b9b9>] ? sched_clock+0x9/0x10
[  106.751225]  [<ffffffff8134a68d>] aa_path_perm+0x7d/0x170
[  106.751250]  [<ffffffff8101b945>] ? native_sched_clock+0x15/0x80
[  106.751276]  [<ffffffff8134aa73>] aa_file_perm+0x33/0x40
[  106.751301]  [<ffffffff81348c5e>] common_file_perm+0x8e/0xb0
[  106.751327]  [<ffffffff81348d78>] apparmor_file_permission+0x18/0x20
[  106.751355]  [<ffffffff8130c853>] security_file_permission+0x23/0xa0
[  106.751382]  [<ffffffff811c77a2>] rw_verify_area+0x52/0xe0
[  106.751407]  [<ffffffff811c789d>] vfs_read+0x6d/0x170
[  106.751432]  [<ffffffff811cda31>] kernel_read+0x41/0x60
[  106.751457]  [<ffffffff8134fd45>] ima_calc_file_hash+0x225/0x280
[  106.751483]  [<ffffffff8134fb52>] ? ima_calc_file_hash+0x32/0x280
[  106.751509]  [<ffffffff8135022d>] ima_collect_measurement+0x9d/0x160
[  106.751536]  [<ffffffff810b552d>] ? trace_hardirqs_on+0xd/0x10
[  106.751562]  [<ffffffff8134f07c>] ? ima_file_free+0x6c/0xd0
[  106.751587]  [<ffffffff81352824>] ima_update_xattr+0x34/0x60
[  106.751612]  [<ffffffff8134f0d0>] ima_file_free+0xc0/0xd0
[  106.751637]  [<ffffffff811c9635>] __fput+0xd5/0x300
[  106.751662]  [<ffffffff811c98ae>] ____fput+0xe/0x10
[  106.751687]  [<ffffffff81086774>] task_work_run+0xc4/0xe0
[  106.751712]  [<ffffffff81066fad>] do_exit+0x2bd/0xa90
[  106.751738]  [<ffffffff8173c958>] ? retint_swapgs+0x13/0x1b
[  106.751763]  [<ffffffff8106780c>] do_group_exit+0x4c/0xc0
[  106.751788]  [<ffffffff81067894>] SyS_exit_group+0x14/0x20
[  106.751814]  [<ffffffff8174522d>] system_call_fastpath+0x1a/0x1f
[  106.751839] Code: c3 0f 1f 44 00 00 55 48 89 e5 e8 22 fe ff ff 5d c3
0f 1f 44 00 00 55 65 48 8b 04 25 c0 c9 00 00 48 8b 80 28 06 00 00 48 89
e5 5d <48> 8b 40 18 48 39 87 c0 00 00 00 0f 94 c0 c3 0f 1f 80 00 00 00
[  106.752185] RIP  [<ffffffff811ec7da>] our_mnt+0x1a/0x30
[  106.752214]  RSP <ffff880400fcba60>
[  106.752236] CR2: 0000000000000018
[  106.752258] ---[ end trace 3c520748b4732721 ]---
----------------------------------------------------------------------

The reason for the oops is that IMA-appraisal uses "kernel_read()" when
file is closed. kernel_read() honors LSM security hook which calls
Apparmor handler, which uses current->nsproxy->mnt_ns. The 'guilty'
commit changed the order of cleanup code so that nsproxy->mnt_ns was
not already available for Apparmor.

Discussion about the issue with Al Viro and Eric W. Biederman suggested
that kernel_read() is too high-level for IMA. Another issue, except
security checking, that was identified is mandatory locking. kernel_read
honors it as well and it might prevent IMA from calculating necessary hash.
It was suggested to use simplified version of the function without security
and locking checks.

This patch introduces special version ima_kernel_read(), which skips security
and mandatory locking checking. It prevents the kernel oops to happen.

Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com>
Suggested-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org>
 0430e49
@ljalves
Owner

ljalves commented Jun 25, 2014

Hmmm, this may be related to the tuner settings.
You have the TBS6922 (non-SE) ?
Can you put here check the chips used in the card?
I mainly need to know the demod (should be something like TAS2101?) and tuner (AV2011?)

@ljalves ljalves added enhancement bug labels Jun 25, 2014

@Alfredo-

Alfredo- commented Jun 25, 2014

Hi Luis

El 25/06/14 11:20, Luis Alves escribió:

Hmmm, this may be related to the tuner settings.

Yeah, that seems

You have the TBS6922 (non-SE) ?

Only TBS6922 (the old card).

Can you put here check the chips used in the card?
I mainly need to know the demod (should be something like TAS2101?)
and tuner (AV2011?)

Big chip:

Tmax
TAS2100
-CL100
T1110
T4H072F13

small chip

SAA7160ET
Q737NTV
02
2S10502
Trident

Sorry, I can't see the tuner. It is under shield.

Regards

@ljalves ljalves pushed a commit that referenced this issue Jul 17, 2014

@torvalds Wengang Wang + torvalds ocfs2: refcount: take rw_lock in ocfs2_reflink 
This patch tries to fix this crash:

 #5 [ffff88003c1cd690] do_invalid_op at ffffffff810166d5
 #6 [ffff88003c1cd730] invalid_op at ffffffff8159b2de
    [exception RIP: ocfs2_direct_IO_get_blocks+359]
    RIP: ffffffffa05dfa27  RSP: ffff88003c1cd7e8  RFLAGS: 00010202
    RAX: 0000000000000000  RBX: ffff88003c1cdaa8  RCX: 0000000000000000
    RDX: 000000000000000c  RSI: ffff880027a95000  RDI: ffff88003c79b540
    RBP: ffff88003c1cd858   R8: 0000000000000000   R9: ffffffff815f6ba0
    R10: 00000000000001c9  R11: 00000000000001c9  R12: ffff88002d271500
    R13: 0000000000000001  R14: 0000000000000000  R15: 0000000000001000
    ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
 #7 [ffff88003c1cd860] do_direct_IO at ffffffff811cd31b
 #8 [ffff88003c1cd950] direct_IO_iovec at ffffffff811cde9c
 #9 [ffff88003c1cd9b0] do_blockdev_direct_IO at ffffffff811ce764
#10 [ffff88003c1cdb80] __blockdev_direct_IO at ffffffff811ce7cc
#11 [ffff88003c1cdbb0] ocfs2_direct_IO at ffffffffa05df756 [ocfs2]
#12 [ffff88003c1cdbe0] generic_file_direct_write_iter at ffffffff8112f935
#13 [ffff88003c1cdc40] ocfs2_file_write_iter at ffffffffa0600ccc [ocfs2]
#14 [ffff88003c1cdd50] do_aio_write at ffffffff8119126c
#15 [ffff88003c1cddc0] aio_rw_vect_retry at ffffffff811d9bb4
#16 [ffff88003c1cddf0] aio_run_iocb at ffffffff811db880
#17 [ffff88003c1cde30] io_submit_one at ffffffff811dc238
#18 [ffff88003c1cde80] do_io_submit at ffffffff811dc437
#19 [ffff88003c1cdf70] sys_io_submit at ffffffff811dc530
#20 [ffff88003c1cdf80] system_call_fastpath at ffffffff8159a159

It crashes at
        BUG_ON(create && (ext_flags & OCFS2_EXT_REFCOUNTED));
in ocfs2_direct_IO_get_blocks.

ocfs2_direct_IO_get_blocks is expecting the OCFS2_EXT_REFCOUNTED be removed in
ocfs2_prepare_inode_for_write() if it was there. But no cluster lock is taken
during the time before (or inside) ocfs2_prepare_inode_for_write() and after
ocfs2_direct_IO_get_blocks().

It can happen in this case:

Node A(which crashes)				Node B
------------------------                 ---------------------------
ocfs2_file_aio_write
  ocfs2_prepare_inode_for_write
    ocfs2_inode_lock
    ...
    ocfs2_inode_unlock
  #no refcount found
....					ocfs2_reflink
                                          ocfs2_inode_lock
                                          ...
                                          ocfs2_inode_unlock
                                          #now, refcount flag set on extent

                                        ...
                                        flush change to disk

ocfs2_direct_IO_get_blocks
  ocfs2_get_clusters
    #extent map miss
    #buffer_head miss
    read extents from disk
  found refcount flag on extent
  crash..

Fix:
Take rw_lock in ocfs2_reflink path

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
 8a8ad1c
@ljalves
Owner

ljalves commented Jul 19, 2014

I've changed the tuner init for the tbs6922.
Please test using 'latest' branch.
@Alfredo-

Alfredo- commented Jul 20, 2014

Hi
Without change.

Subjectively: perhaps a little better picture (see my previous posts) 10 or 15%.

Thanks,

Alfredo
@ljalves
Owner

ljalves commented Jul 20, 2014

I think I found the issue.
Let me commit the changes (probably tomorrow) and them I'll ask you to re-test.
@Alfredo-

Alfredo- commented Jul 20, 2014

OK, I wait for the patch

If you do not have the card TBS6922 --> (Thanks)²
@ljalves
Owner

ljalves commented Jul 21, 2014

Hi @Alfredo-

Please update the tree to the 'latest' branch and retry.
Please report if it works now.
@Alfredo-

Alfredo- commented Jul 21, 2014

Hi Luis

The Free driver is working, but I need more time for test.

Thank you very much,

Alfredo
@ljalves
Owner

ljalves commented Jul 22, 2014

Great that it works. Closing this issue. Fell free to re-open it if you encounter any problem.

ljalves closed this Jul 22, 2014

@ljalves ljalves pushed a commit that referenced this issue Nov 11, 2014

@pranith @mpe pranith + mpe powerpc: Wire up sys_bpf() syscall 
This patch wires up the new syscall sys_bpf() on powerpc.

Passes the tests in samples/bpf:

    #0 add+sub+mul OK
    #1 unreachable OK
    #2 unreachable2 OK
    #3 out of range jump OK
    #4 out of range jump2 OK
    #5 test1 ld_imm64 OK
    #6 test2 ld_imm64 OK
    #7 test3 ld_imm64 OK
    #8 test4 ld_imm64 OK
    #9 test5 ld_imm64 OK
    #10 no bpf_exit OK
    #11 loop (back-edge) OK
    #12 loop2 (back-edge) OK
    #13 conditional loop OK
    #14 read uninitialized register OK
    #15 read invalid register OK
    #16 program doesn't init R0 before exit OK
    #17 stack out of bounds OK
    #18 invalid call insn1 OK
    #19 invalid call insn2 OK
    #20 invalid function call OK
    #21 uninitialized stack1 OK
    #22 uninitialized stack2 OK
    #23 check valid spill/fill OK
    #24 check corrupted spill/fill OK
    #25 invalid src register in STX OK
    #26 invalid dst register in STX OK
    #27 invalid dst register in ST OK
    #28 invalid src register in LDX OK
    #29 invalid dst register in LDX OK
    #30 junk insn OK
    #31 junk insn2 OK
    #32 junk insn3 OK
    #33 junk insn4 OK
    #34 junk insn5 OK
    #35 misaligned read from stack OK
    #36 invalid map_fd for function call OK
    #37 don't check return value before access OK
    #38 access memory with incorrect alignment OK
    #39 sometimes access memory with incorrect alignment OK
    #40 jump test 1 OK
    #41 jump test 2 OK
    #42 jump test 3 OK
    #43 jump test 4 OK

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
[mpe: test using samples/bpf]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
 fcbb539

@crazycat69 crazycat69 referenced this issue in crazycat69/linux_media Oct 10, 2016

@chucklever chucklever + J. Bruce Fields svcauth_gss: Revert 64c59a3 ("Remove unnecessary allocation") 
rsc_lookup steals the passed-in memory to avoid doing an allocation of
its own, so we can't just pass in a pointer to memory that someone else
is using.

If we really want to avoid allocation there then maybe we should
preallocate somwhere, or reference count these handles.

For now we should revert.

On occasion I see this on my server:

kernel: kernel BUG at /home/cel/src/linux/linux-2.6/mm/slub.c:3851!
kernel: invalid opcode: 0000 [#1] SMP
kernel: Modules linked in: cts rpcsec_gss_krb5 sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd btrfs xor iTCO_wdt iTCO_vendor_support raid6_pq pcspkr i2c_i801 i2c_smbus lpc_ich mfd_core mei_me sg mei shpchp wmi ioatdma ipmi_si ipmi_msghandler acpi_pad acpi_power_meter rpcrdma ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm nfsd nfs_acl lockd grace auth_rpcgss sunrpc ip_tables xfs libcrc32c mlx4_ib mlx4_en ib_core sr_mod cdrom sd_mod ast drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm drm crc32c_intel igb mlx4_core ahci libahci libata ptp pps_core dca i2c_algo_bit i2c_core dm_mirror dm_region_hash dm_log dm_mod
kernel: CPU: 7 PID: 145 Comm: kworker/7:2 Not tainted 4.8.0-rc4-00006-g9d06b0b #15
kernel: Hardware name: Supermicro Super Server/X10SRL-F, BIOS 1.0c 09/09/2015
kernel: Workqueue: events do_cache_clean [sunrpc]
kernel: task: ffff8808541d8000 task.stack: ffff880854344000
kernel: RIP: 0010:[<ffffffff811e7075>]  [<ffffffff811e7075>] kfree+0x155/0x180
kernel: RSP: 0018:ffff880854347d70  EFLAGS: 00010246
kernel: RAX: ffffea0020fe7660 RBX: ffff88083f9db064 RCX: 146ff0f9d5ec5600
kernel: RDX: 000077ff80000000 RSI: ffff880853f01500 RDI: ffff88083f9db064
kernel: RBP: ffff880854347d88 R08: ffff8808594ee000 R09: ffff88087fdd8780
kernel: R10: 0000000000000000 R11: ffffea0020fe76c0 R12: ffff880853f01500
kernel: R13: ffffffffa013cf76 R14: ffffffffa013cff0 R15: ffffffffa04253a0
kernel: FS:  0000000000000000(0000) GS:ffff88087fdc0000(0000) knlGS:0000000000000000
kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
kernel: CR2: 00007fed60b020c3 CR3: 0000000001c06000 CR4: 00000000001406e0
kernel: Stack:
kernel: ffff8808589f2f00 ffff880853f01500 0000000000000001 ffff880854347da0
kernel: ffffffffa013cf76 ffff8808589f2f00 ffff880854347db8 ffffffffa013d006
kernel: ffff8808589f2f20 ffff880854347e00 ffffffffa0406f60 0000000057c7044f
kernel: Call Trace:
kernel: [<ffffffffa013cf76>] rsc_free+0x16/0x90 [auth_rpcgss]
kernel: [<ffffffffa013d006>] rsc_put+0x16/0x30 [auth_rpcgss]
kernel: [<ffffffffa0406f60>] cache_clean+0x2e0/0x300 [sunrpc]
kernel: [<ffffffffa04073ee>] do_cache_clean+0xe/0x70 [sunrpc]
kernel: [<ffffffff8109a70f>] process_one_work+0x1ff/0x3b0
kernel: [<ffffffff8109b15c>] worker_thread+0x2bc/0x4a0
kernel: [<ffffffff8109aea0>] ? rescuer_thread+0x3a0/0x3a0
kernel: [<ffffffff810a0ba4>] kthread+0xe4/0xf0
kernel: [<ffffffff8169c47f>] ret_from_fork+0x1f/0x40
kernel: [<ffffffff810a0ac0>] ? kthread_stop+0x110/0x110
kernel: Code: f7 ff ff eb 3b 65 8b 05 da 30 e2 7e 89 c0 48 0f a3 05 a0 38 b8 00 0f 92 c0 84 c0 0f 85 d1 fe ff ff 0f 1f 44 00 00 e9 f5 fe ff ff <0f> 0b 49 8b 03 31 f6 f6 c4 40 0f 85 62 ff ff ff e9 61 ff ff ff
kernel: RIP  [<ffffffff811e7075>] kfree+0x155/0x180
kernel: RSP <ffff880854347d70>
kernel: ---[ end trace 3fdec044969def26 ]---

It seems to be most common after a server reboot where a client has been
using a Kerberos mount, and reconnects to continue its workload.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
 bf2c4b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment