Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict between TBS6281 and TBS6982 #40

Closed
andrewjw opened this issue Oct 25, 2014 · 4 comments
Closed

Conflict between TBS6281 and TBS6982 #40

andrewjw opened this issue Oct 25, 2014 · 4 comments
Assignees
@ljalves

Comments

@andrewjw
Copy link

Hi,

I have both a 6281 (dvb-t2) and 6982 (dvb-s2) card in my machine. Both use the sa716x_budget module.. The 6281 appears to work ok (although is dvb-t only, but that's a different problem). The 6982 won't tune into anything and fills the logs with the messages below. It looks like the card is crashing and is resetting? Do you think they require different firmwares, or there is some other conflict between them?

Oct 26 00:09:34 tv kernel: [ 1617.452786] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in cold state
Oct 26 00:09:34 tv kernel: [ 1617.452817] si2168 13-0064: si2168: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
Oct 26 00:09:34 tv kernel: [ 1617.597414] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in warm state
Oct 26 00:09:34 tv kernel: [ 1617.599947] si2157 14-0060: si2157: found a 'Silicon Labs Si2157/Si2158' in cold state
Oct 26 00:09:34 tv kernel: [ 1617.599967] si2157 14-0060: si2157: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw'
Oct 26 00:09:34 tv kernel: [ 1617.822973] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in cold state
Oct 26 00:09:34 tv kernel: [ 1617.822984] si2168 13-0064: si2168: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
Oct 26 00:09:34 tv kernel: [ 1617.967604] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in warm state
Oct 26 00:09:34 tv kernel: [ 1617.970144] si2157 14-0060: si2157: found a 'Silicon Labs Si2157/Si2158' in cold state
Oct 26 00:09:34 tv kernel: [ 1617.970151] si2157 14-0060: si2157: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw'
Oct 26 00:09:44 tv kernel: [ 1627.233412] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in cold state
Oct 26 00:09:44 tv kernel: [ 1627.233438] si2168 13-0064: si2168: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
Oct 26 00:09:44 tv kernel: [ 1627.378094] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in warm state
Oct 26 00:09:44 tv kernel: [ 1627.380607] si2157 14-0060: si2157: found a 'Silicon Labs Si2157/Si2158' in cold state
Oct 26 00:09:44 tv kernel: [ 1627.380626] si2157 14-0060: si2157: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw'
Oct 26 00:09:44 tv kernel: [ 1627.603332] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in cold state
Oct 26 00:09:44 tv kernel: [ 1627.603345] si2168 13-0064: si2168: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
Oct 26 00:09:44 tv kernel: [ 1627.747968] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in warm state
Oct 26 00:09:44 tv kernel: [ 1627.750484] si2157 14-0060: si2157: found a 'Silicon Labs Si2157/Si2158' in cold state
Oct 26 00:09:44 tv kernel: [ 1627.750502] si2157 14-0060: si2157: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw'
Oct 26 00:09:44 tv kernel: [ 1627.973225] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in cold state
Oct 26 00:09:44 tv kernel: [ 1627.973237] si2168 13-0064: si2168: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
Oct 26 00:09:44 tv kernel: [ 1628.117947] si2168 13-0064: si2168: found a 'Silicon Labs Si2168' in warm state
Oct 26 00:09:44 tv kernel: [ 1628.120456] si2157 14-0060: si2157: found a 'Silicon Labs Si2157/Si2158' in cold state
Oct 26 00:09:44 tv kernel: [ 1628.120473] si2157 14-0060: si2157: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw'

Many thanks for your work on these drivers,
Andrew
ljalves pushed a commit that referenced this issue Nov 11, 2014
@pranith @mpe
powerpc: Wire up sys_bpf() syscall
fcbb539 
This patch wires up the new syscall sys_bpf() on powerpc.

Passes the tests in samples/bpf:

    #0 add+sub+mul OK
    #1 unreachable OK
    #2 unreachable2 OK
    #3 out of range jump OK
    #4 out of range jump2 OK
    #5 test1 ld_imm64 OK
    #6 test2 ld_imm64 OK
    #7 test3 ld_imm64 OK
    #8 test4 ld_imm64 OK
    #9 test5 ld_imm64 OK
    #10 no bpf_exit OK
    #11 loop (back-edge) OK
    #12 loop2 (back-edge) OK
    #13 conditional loop OK
    #14 read uninitialized register OK
    #15 read invalid register OK
    #16 program doesn't init R0 before exit OK
    #17 stack out of bounds OK
    #18 invalid call insn1 OK
    #19 invalid call insn2 OK
    #20 invalid function call OK
    #21 uninitialized stack1 OK
    #22 uninitialized stack2 OK
    #23 check valid spill/fill OK
    #24 check corrupted spill/fill OK
    #25 invalid src register in STX OK
    #26 invalid dst register in STX OK
    #27 invalid dst register in ST OK
    #28 invalid src register in LDX OK
    #29 invalid dst register in LDX OK
    #30 junk insn OK
    #31 junk insn2 OK
    #32 junk insn3 OK
    #33 junk insn4 OK
    #34 junk insn5 OK
    #35 misaligned read from stack OK
    #36 invalid map_fd for function call OK
    #37 don't check return value before access OK
    #38 access memory with incorrect alignment OK
    #39 sometimes access memory with incorrect alignment OK
    #40 jump test 1 OK
    #41 jump test 2 OK
    #42 jump test 3 OK
    #43 jump test 4 OK

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
[mpe: test using samples/bpf]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
@ljalves
Copy link
Owner

ljalves commented Nov 15, 2014

Please update to the latest tree and re-test.
Some fixes were applied to the saa716x driver.
Report back once tested.

@andrewjw
Copy link
Author

Initial test look positive. The dvb devices have appeared and I'm able to
tune in and watch tv on both cards. I'll do some more extensive checks over
the weekend, but it looks good so far.

On Saturday, 15 November 2014, Luis Alves notifications@github.com wrote:

Please update to the latest tree and re-test.
Some fixes were applied to the saa716x driver.
Report back once tested.

—
Reply to this email directly or view it on GitHub
#40 (comment).

@ljalves ljalves self-assigned this Nov 15, 2014
@ljalves
Copy link
Owner

ljalves commented Nov 15, 2014

Great!
Looking forward to hear about your results.

@andrewjw
Copy link
Author

Everything looks good now. I was able to watch 2 hours of TV with no problem, and MythTV did a complete channel scan and is picking up EIT data.

Thanks,
Andrew

@kapitanf kapitanf mentioned this issue Oct 5, 2017
Open
crazycat69 pushed a commit to crazycat69/linux_media that referenced this issue Jul 2, 2021
@ZheyuMa @mchehab
media: bt8xx: Fix a missing check bug in bt878_probe
1a45200 
In 'bt878_irq', the driver calls 'tasklet_schedule', but this tasklet is
set in 'dvb_bt8xx_load_card' of another driver 'dvb-bt8xx'.
However, this two drivers are separate. The user may not load the
'dvb-bt8xx' driver when loading the 'bt8xx' driver, that is, the tasklet
has not been initialized when 'tasklet_schedule' is called, so it is
necessary to check whether the tasklet is initialized in 'bt878_probe'.

Fix this by adding a check at the end of bt878_probe.

The KASAN's report reveals it:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
PGD 800000006aab2067 P4D 800000006aab2067 PUD 6b2ea067 PMD 0
Oops: 0010 [ljalves#1] PREEMPT SMP KASAN PTI
CPU: 2 PID: 8724 Comm: syz-executor.0 Not tainted 4.19.177-
gdba4159c14ef-dirty ljalves#40
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-
gc9ba5276e321-prebuilt.qemu.org 04/01/2014
RIP: 0010:          (null)
Code: Bad RIP value.
RSP: 0018:ffff88806c287ea0 EFLAGS: 00010246
RAX: fffffbfff1b01774 RBX: dffffc0000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 1ffffffff1b01775 RDI: 0000000000000000
RBP: ffff88806c287f00 R08: fffffbfff1b01774 R09: fffffbfff1b01774
R10: 0000000000000001 R11: fffffbfff1b01773 R12: 0000000000000000
R13: ffff88806c29f530 R14: ffffffff8d80bb88 R15: ffffffff8d80bb90
FS:  00007f6b550e6700(0000) GS:ffff88806c280000(0000) knlGS:
0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 000000005ec98000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <IRQ>
 tasklet_action_common.isra.17+0x141/0x420 kernel/softirq.c:522
 tasklet_action+0x50/0x70 kernel/softirq.c:540
 __do_softirq+0x224/0x92c kernel/softirq.c:292
 invoke_softirq kernel/softirq.c:372 [inline]
 irq_exit+0x15a/0x180 kernel/softirq.c:412
 exiting_irq arch/x86/include/asm/apic.h:535 [inline]
 do_IRQ+0x123/0x1e0 arch/x86/kernel/irq.c:260
 common_interrupt+0xf/0xf arch/x86/entry/entry_64.S:670
 </IRQ>
RIP: 0010:__do_sys_interrupt kernel/sys.c:2593 [inline]
RIP: 0010:__se_sys_interrupt kernel/sys.c:2584 [inline]
RIP: 0010:__x64_sys_interrupt+0x5b/0x80 kernel/sys.c:2584
Code: ba 00 04 00 00 48 c7 c7 c0 99 31 8c e8 ae 76 5e 01 48 85 c0 75 21 e8
14 ae 24 00 48 c7 c3 c0 99 31 8c b8 0c 00 00 00 0f 01 c1 <31> db e8 fe ad
24 00 48 89 d8 5b 5d c3 48 c7 c3 ea ff ff ff eb ec
RSP: 0018:ffff888054167f10 EFLAGS: 00000212 ORIG_RAX: ffffffffffffffde
RAX: 000000000000000c RBX: ffffffff8c3199c0 RCX: ffffc90001ca6000
RDX: 000000000000001a RSI: ffffffff813478fc RDI: ffffffff8c319dc0
RBP: ffff888054167f18 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000080 R11: fffffbfff18633b7 R12: ffff888054167f58
R13: ffff88805f638000 R14: 0000000000000000 R15: 0000000000000000
 do_syscall_64+0xb0/0x4e0 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4692a9
Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6b550e5c48 EFLAGS: 00000246 ORIG_RAX: 000000000000014f
RAX: ffffffffffffffda RBX: 000000000077bf60 RCX: 00000000004692a9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000140
RBP: 00000000004cf7eb R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000077bf60
R13: 0000000000000000 R14: 000000000077bf60 R15: 00007fff55a1dca0
Modules linked in:
Dumping ftrace buffer:
   (ftrace buffer empty)
CR2: 0000000000000000
---[ end trace 68e5849c3f77cbb6 ]---
RIP: 0010:          (null)
Code: Bad RIP value.
RSP: 0018:ffff88806c287ea0 EFLAGS: 00010246
RAX: fffffbfff1b01774 RBX: dffffc0000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 1ffffffff1b01775 RDI: 0000000000000000
RBP: ffff88806c287f00 R08: fffffbfff1b01774 R09: fffffbfff1b01774
R10: 0000000000000001 R11: fffffbfff1b01773 R12: 0000000000000000
R13: ffff88806c29f530 R14: ffffffff8d80bb88 R15: ffffffff8d80bb90
FS:  00007f6b550e6700(0000) GS:ffff88806c280000(0000) knlGS:
0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 000000005ec98000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
crazycat69 pushed a commit to crazycat69/linux_media that referenced this issue Apr 8, 2022
ARM: 9191/1: arm/stacktrace, kasan: Silence KASAN warnings in unwind_…
9be4c88 
…frame()

The following KASAN warning is detected by QEMU.

==================================================================
BUG: KASAN: stack-out-of-bounds in unwind_frame+0x508/0x870
Read of size 4 at addr c36bba90 by task cat/163

CPU: 1 PID: 163 Comm: cat Not tainted 5.10.0-rc1 ljalves#40
Hardware name: ARM-Versatile Express
[<c0113fac>] (unwind_backtrace) from [<c010e71c>] (show_stack+0x10/0x14)
[<c010e71c>] (show_stack) from [<c0b805b4>] (dump_stack+0x98/0xb0)
[<c0b805b4>] (dump_stack) from [<c0b7d658>] (print_address_description.constprop.0+0x58/0x4bc)
[<c0b7d658>] (print_address_description.constprop.0) from [<c031435c>] (kasan_report+0x154/0x170)
[<c031435c>] (kasan_report) from [<c0113c44>] (unwind_frame+0x508/0x870)
[<c0113c44>] (unwind_frame) from [<c010e298>] (__save_stack_trace+0x110/0x134)
[<c010e298>] (__save_stack_trace) from [<c01ce0d8>] (stack_trace_save+0x8c/0xb4)
[<c01ce0d8>] (stack_trace_save) from [<c0313520>] (kasan_set_track+0x38/0x60)
[<c0313520>] (kasan_set_track) from [<c0314cb8>] (kasan_set_free_info+0x20/0x2c)
[<c0314cb8>] (kasan_set_free_info) from [<c0313474>] (__kasan_slab_free+0xec/0x120)
[<c0313474>] (__kasan_slab_free) from [<c0311e20>] (kmem_cache_free+0x7c/0x334)
[<c0311e20>] (kmem_cache_free) from [<c01c35dc>] (rcu_core+0x390/0xccc)
[<c01c35dc>] (rcu_core) from [<c01013a8>] (__do_softirq+0x180/0x518)
[<c01013a8>] (__do_softirq) from [<c0135214>] (irq_exit+0x9c/0xe0)
[<c0135214>] (irq_exit) from [<c01a40e4>] (__handle_domain_irq+0xb0/0x110)
[<c01a40e4>] (__handle_domain_irq) from [<c0691248>] (gic_handle_irq+0xa0/0xb8)
[<c0691248>] (gic_handle_irq) from [<c0100b0c>] (__irq_svc+0x6c/0x94)
Exception stack(0xc36bb928 to 0xc36bb970)
b920:                   c36bb9c0 00000000 c0126919 c0101228 c36bb9c0 b76d7730
b940: c36b8000 c36bb9a0 c3335b00 c01ce0d8 00000003 c36bba3c c36bb940 c36bb978
b960: c010e298 c011373c 60000013 ffffffff
[<c0100b0c>] (__irq_svc) from [<c011373c>] (unwind_frame+0x0/0x870)
[<c011373c>] (unwind_frame) from [<00000000>] (0x0)

The buggy address belongs to the page:
page:(ptrval) refcount:0 mapcount:0 mapping:00000000 index:0x0 pfn:0x636bb
flags: 0x0()
raw: 00000000 00000000 ef867764 00000000 00000000 00000000 ffffffff 00000000
page dumped because: kasan: bad access detected

addr c36bba90 is located in stack of task cat/163 at offset 48 in frame:
 stack_trace_save+0x0/0xb4

this frame has 1 object:
 [32, 48) 'trace'

Memory state around the buggy address:
 c36bb980: f1 f1 f1 f1 00 04 f2 f2 00 00 f3 f3 00 00 00 00
 c36bba00: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1
>c36bba80: 00 00 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
                 ^
 c36bbb00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 c36bbb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================

There is a same issue on x86 and has been resolved by the commit f7d27c3
("x86/mm, kasan: Silence KASAN warnings in get_wchan()").
The solution could be applied to arm architecture too.

Signed-off-by: Lin Yujun <linyujun809@huawei.com>
Reported-by: He Ying <heying24@huawei.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljalves ljalves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewjw @ljalves