Throw error on circular references

[richarddd]

Currently the library does not throw error when parsing circual references.

Example:

const circular = {
   a : "value"
}
circular.a = circular
JSON.stringify(circular) //throws error

const circular = {
   a : "value"
}
circular.a = circular
qs.stringify(circular) //freezes computer 😣

[ljharb]

Related to #31; seems like maybe we need the same treatment for stringify.

[Poyoman39]

What about a "maxDepth" option ?
I will make a PR for this

[Poyoman39]

Just to know. What is the targeted browser compatibility of qs ? I would have a solution working with JavaScript "Map" ... but it's not available in IE10 <=

[ljharb]

@Poyoman39 its much older than that, I’m afraid. Map can be shimmed (and should always be), but qs can’t rely on that being the case. However, we could build a fake Map with an array if WeakMap/Map isn’t available

[Poyoman39]

Ok i did a throw / Map solution (second PR) . I wanted to use Map for performance reasons. But maybe it's a bit of overOptiomisation ? Since querystrings does not contains that much keys ??? It would be possible to do it with a simple array ... les performant, but without requiring a Shim ?

What do you think ?

[Poyoman39]

Ok last PR, this time with array way :D #395

We have some choice for this one issue :D

[ljharb]

Ok please stop creating extra PRs tho - each PR is a permanent ref on the repo, so how i have 3 PRs to keep in sync :-)

[Poyoman39]

Ok sry for this ^^ Do you want i close some of them ?

[ljharb]

No, please leave them all open - whatever solution we go with, I’ll update all three PRs to have it as part of landing.