Square brackets should be URI encoded #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a breaking change and a drastic deviation from the original qs library. As you can see, it breaks quite a few of the stringify tests. This is definitely one that requires more discussion before being merged. |
|
Yeah, sorry for not looking through the tests! |
|
I'm not sure, but I'll do a little testing. I think there's a better place to do the encoding if it's necessary, too. |
|
Closed via 5b63418 |
Morita0711
added a commit
to Morita0711/npm-superurgent
that referenced
this pull request
Jul 3, 2022
qs had the following breaking changes: - Square brackets get urlencoded (see: ljharb/qs#8) - Use date.toISOString() for date serialization (see: ljharb/qs@e473156) Also update better-assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.