-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Exclude fs
from browser bundlers
#565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 4 4
Lines 627 627
Branches 145 145
=======================================
Hits 605 605
Misses 22 22 Continue to review full report at Codecov.
|
ljharb
changed the title
Exclude
[meta] Exclude Sep 13, 2021
fs
from some browser bundlersfs
from browser bundlers
Thanks! |
ljharb
added a commit
that referenced
this pull request
Nov 16, 2021
- [Fix] use `file://` URLs for dynamic `import()` (#571, #559) - [readme] hard wraps bad, soft wraps good - [readme] fix markdown; github still has a rendering bug - [readme] add badges - [meta] Exclude `fs` from browser bundles (#565) - [Deps] update `glob`, `string.prototype.trim` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `safe-publish-latest`, `array.prototype.flatmap` - [actions] update codecov uploader - [Tests] handle carriage returns in stack traces on Windows - [Tests] node 17+ smooshes a version number on the end of the stack trace - [Tests] handle v8 6.9 changing an error message
ljharb
pushed a commit
that referenced
this pull request
Jan 26, 2022
ljharb
added a commit
that referenced
this pull request
Jan 26, 2022
- [New] add `--no-only` flag/`NODE_TAPE_NO_ONLY_TEST` (#572) - [New] `t.match`/`t.doesNotMatch: fail the test instead of throw on wrong input types. - [Fix] `bin/tape`: delay requires until needed - [Robustness] use cached `.test` - [readme] hard wraps bad, soft wraps good - [readme] port changes from v5 - [meta] fix `prelint` so it does not fail outside of a git repo - [meta] better `eccheck` command - [meta] Exclude `fs` from browser bundles (#565) - [actions] reuse common workflows - [actions] update codecov uploader - [Deps] update `object-inspect`, `resolve`, `glob`, `is-regex`, `string.prototype.trim` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `safe-publish-latest`, `array.prototype.flatmap` - [Tests] handle a broken error `cause` in node 16.9/16.10 - [Tests] handle carriage returns in stack traces on Windows
ljharb
added a commit
that referenced
this pull request
Jan 26, 2022
v4.15.0 - [New] add `--no-only` flag/`NODE_TAPE_NO_ONLY_TEST` (#572) - [New] `t.match`/`t.doesNotMatch: fail the test instead of throw on wrong input types. - [Fix] `bin/tape`: delay requires until needed - [Robustness] use cached `.test` - [readme] hard wraps bad, soft wraps good - [readme] port changes from v5 - [meta] fix `prelint` so it does not fail outside of a git repo - [meta] better `eccheck` command - [meta] Exclude `fs` from browser bundles (#565) - [actions] reuse common workflows - [actions] update codecov uploader - [Deps] update `object-inspect`, `resolve`, `glob`, `is-regex`, `string.prototype.trim` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `safe-publish-latest`, `array.prototype.flatmap` - [Tests] handle a broken error `cause` in node 16.9/16.10 - [Tests] handle carriage returns in stack traces on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #561 (comment) and verified in #561 (comment)
In short this change will let:
fs
dependency altogether