Skip to content
This repository has been archived by the owner on Sep 24, 2023. It is now read-only.

Optimisation/Refactor in Config and Item #19

Closed
LJSkinner opened this issue Feb 25, 2023 · 1 comment · Fixed by #21
Closed

Optimisation/Refactor in Config and Item #19

LJSkinner opened this issue Feb 25, 2023 · 1 comment · Fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@LJSkinner
Copy link
Owner

There's some cleaning up I could do, particularly in the class that handles the Config options. There's also a few things I had missed in the main Item class that could be changed, such as some methods being non-static where they probably should be.

As these don't appear to be the cause of the bug (from my testing) that is happening to some people in #15 I will ship these changes with the update to MC 1.19.4.

@LJSkinner LJSkinner added the enhancement New feature or request label Feb 25, 2023
@LJSkinner LJSkinner self-assigned this Feb 25, 2023
@LJSkinner
Copy link
Owner Author

LJSkinner commented Mar 10, 2023

Planning on now shipping these changes for current versions. I will release for the most recent versions 1.19.3 and 1.18.2. As these are more subtle improvements, I will be leaving MC 1.19.2 as is. But every subsequent version will have these cahnges.

LJSkinner added a commit that referenced this issue Mar 10, 2023
Add init of default entities to new method addDefaultEntities()

refs #19
LJSkinner added a commit that referenced this issue Mar 10, 2023
Add init of default entities to new method addDefaultEntities()

refs #19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant