Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar improvements in LabyrinthJS.activity #1073

Closed
S-kus opened this issue May 8, 2022 · 4 comments
Closed

Toolbar improvements in LabyrinthJS.activity #1073

S-kus opened this issue May 8, 2022 · 4 comments
Labels
enhancement to be release Fixed, to be release
Milestone
v1.7

Comments

@S-kus
Copy link
Contributor

S-kus commented May 8, 2022 •
edited
Loading

  1. Currently sub-toolbar is overlapping with activity-palette, as shown:

    laby1

    It should be like this:
    2laby

  2. The button title of Idea text and the background color is Stroke Color and Fill Color respectively, As shown:

    Screenshot from 2022-05-08 16-38-55

    It can be set to Text Color and Background Color for more specificity.
@S-kus S-kus mentioned this issue May 8, 2022
Merged
@S-kus
Copy link
Contributor Author

S-kus commented May 8, 2022

@llaske I raised the pull request for 1st issue.
Could you please review it and also suggest is 2nd issue needed to be solved or not? If it's required, should I just update the title message in the locale.ini file, or is anything else required?
I will commit for this change in the same pull request.

@llaske
Copy link
Owner

llaske commented May 8, 2022

You're right for 1.
I don't think the text for 2 is confusing.

@S-kus
Copy link
Contributor Author

S-kus commented May 10, 2022

Thanks, @llaske,
I have fixed the 1st issue. Could you please review this pull request?

@llaske
Copy link
Owner

llaske commented May 15, 2022

Fixed in #1074

@llaske llaske added the to be release Fixed, to be release label May 15, 2022
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
2 participants
@llaske @S-kus