background colour of journal-container and body are same in somes activities

[Ayeshashaik759]

when we click on insert option in write activity then a pop up opens in that when we go to search in abecedarium activity then as the background colour of the journal-container and body are same due to this there is no special highligth for background of scrollbar

I just want to suggest that it will nice if the scroll bar have some background colour which can be implemented by changing the background colour of the journal-container. @llaske please share your view on this

somewhat like this

[llaske]

Hmmm. Why not?
BTW I'm not sure that fixing this without side effect is easy.
This feature rely both on CSS and JS components.

[Ayeshashaik759]

yes @llaske you are right I tried to make the changes by changing the code in activities/Write.activity/css/quill/quill.core.css file. By manual testing (i.e by opening it in browser) I observed that all the scroll bars of the write activity are changed hence side effect occurs. so I will try to find some way to change the background of scroll bar only in case of insert image option. Till then any suggestion from all are welcome.

[llaske]

You must not change styles in external libraries because if the library is upgraded your change will be lost.
Plus the issue is the same in other activities (Write for example) so it's not related to Quill library.

[Ayeshashaik759]

Ok i will not change the external libraries instead i will try to get the excepted changes using activity.css

[Ayeshashaik759]

@llaske I think now it is working fine this time I made changes to the activity.css. And the remaining scrollbars are also working fine without any change. I reopened the pr please share your view on it.

[llaske]

Same issue in Paint, Shared Notes and Fototoon.

[Ayeshashaik759]

All the activities inherit same properties and opacity from the library lib/picoModel.js but still difference occurs. Another way to solve this issue and make the scrollbar visible is to change the opacity for this activities but confused with were to make the changes as the changes are not applied by making changes to acticity.css. Ans as we cannot make changes to the libraries.

[llaske]

Fixed in #1184