Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical Errors in the Documentation #347

Closed
IbukunF opened this issue May 26, 2019 · 3 comments
Closed

Grammatical Errors in the Documentation #347

IbukunF opened this issue May 26, 2019 · 3 comments
Labels
documentation to be release Fixed, to be release
Milestone

Comments

@IbukunF
Copy link
Contributor

IbukunF commented May 26, 2019

While I was going through the Sugarizer tutorial, I noticed some areas in the tutorial and the application with grammatical errors:

  1. Step 6 of the tutorial:
  • There is a line that says "Suppose that Michaël, an user connected on the same server than you want to Chat." that could be better written as "Suppose that Michaël, a user connected on the same server as you wants to Chat.".

  • There is another line that says "Then, once the activity will be open, he will share the activity by clicking on the toolbar Neighborhood button in the Network palette." which could also be better written as "Then, once the activity is open, he can share the activity by clicking on the toolbar Neighborhood button in the Network palette."

  1. Step 4 of the tutorial:
  • Says "So an user could expect to retrieve the same number of pawns when he reopen the activity" which could be changed to "So a user could expect to retrieve the same number of pawns when he reopens the activity"
  1. README of EbookReader activity:
  • There is a line that says "An user could change this URL by clicking on the Settings icon of the toolbar." which could be "A user ..."
  1. Finally, In the second screen of the popup modal tutorial, the sentence "First, you need an user to associate your content." could also be changed to "First, you need a user to associate your content with."
@IbukunF
Copy link
Contributor Author

IbukunF commented May 26, 2019

The screen mentioned in 4 is shown here image
I think this can be fixed by modifying the file called template.pot at line 1302 but I would like some feedback first before making that change. The other changes have been made in a pull request.

@llaske please review this when you have a chance

@llaske
Copy link
Owner

llaske commented May 26, 2019

Thanks. Please send a PR on the dev branch.
Regarding error on tutorial screen, the file to update is locale.ini. PO/POT files in Sugarizer are generated from the .ini file. See https://github.com/llaske/sugarizer/tree/dev#localization for more.

@llaske llaske added the to be release Fixed, to be release label Jun 2, 2019
@llaske llaske added this to the v1.2 milestone Jun 2, 2019
@llaske
Copy link
Owner

llaske commented Sep 26, 2019

Closed in dd3c58d

@llaske llaske closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants