Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the clean all button in the Fototoon activity #513

Closed
2 tasks
llaske opened this issue Dec 21, 2019 · 5 comments
Closed
2 tasks

Fix the clean all button in the Fototoon activity #513

llaske opened this issue Dec 21, 2019 · 5 comments
Labels
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Dec 21, 2019

The clean all button in the Fototoon activity toolbar is supposed to remove all content.

image

Currently, it does nothing.
The objective of this issue is:

  • Fix the non working clean all button
  • Add a confirmation box before effectively cleaning all the content

The confirmation box should look like a standard confirmation box in Sugarizer (don't use the standard browser dialog box). Text of the dialog box should be localized.

image

@sarthak-g
Copy link
Contributor

Clean all button is working properly. See:
ezgif com-video-to-gif(1)

I think only confirmation box has to be added.

@llaske
Copy link
Owner Author

llaske commented Dec 24, 2019

Hmmm, look like it works when the activity is reopened from the datastore but not when it was just created. See below:

Peek 24-12-2019 23-49

@sarthak-g
Copy link
Contributor

sarthak-g commented Jan 2, 2020

You want "clean all" button should bring "3 of 3" (as in above) to "1 of 1" ?

@llaske
Copy link
Owner Author

llaske commented Jan 2, 2020

Yes it should be "1 of 1" because the only remaining page should be the first one with title.

@llaske
Copy link
Owner Author

llaske commented Jan 19, 2020

Fixed in #554

@llaske llaske added the to be release Fixed, to be release label Jan 19, 2020
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants