Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fullscreen button in the Stopwatch activity #599

Closed
5 tasks
llaske opened this issue Feb 11, 2020 · 1 comment
Closed
5 tasks

Add a fullscreen button in the Stopwatch activity #599

llaske opened this issue Feb 11, 2020 · 1 comment
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Feb 11, 2020

Sugarizer activities don't look good on devices with small screen - for example smartphones.
On these devices, the toolbar could sometimes take 1/4 of the screen.

To increase the size for activities contents, the idea is to add a fullscreen button in the toolbar like in the QRCode activity. When clicked, the fullscreen button hide the toolbar and display only an unfullscreen button. When clicked, the unfullscreen button show again the toolbar.

This features is implemented here: https://github.com/llaske/sugarizer/blob/dev/activities/QRCode.activity/js/activity.js#L144-L160

The objective of this issue is to implement the same feature in the StopWatch activity.

Thinks to check:

  • The fullscreen button should be on the right of the toolbar, near the Stop button.
  • The fullscreen button should be always visible, including in small screen size. Could require to adapt media queries in CSS.
  • The size of the board should be increase in fullscreen mode. So it means that the resize event should be call directly or indirectly when clicking on fullscreen/unfullscreen button.
  • The unfullscreen button should be visible only when the screen is in fullscreen mode.
  • The unfullscreen button should be attach to the right of the screen. It's better if it's not at the same location than the Stop button to avoid side effect on multiple click.
@llaske
Copy link
Owner Author

llaske commented Feb 18, 2020

Fixed in #607

@llaske llaske added the to be release Fixed, to be release label Feb 18, 2020
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant