This repository has been archived by the owner on Dec 26, 2021. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
13 changed files
with
204 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
|
|
||
| Data Source Analysed | ||
|
|
||
| Directories 20 | ||
| Files 73 | ||
|
|
||
| Size | ||
| Lines of Code (LOC) 3620 | ||
| Comment Lines of Code (CLOC) 137 (3.78%) | ||
| Non-Comment Lines of Code (NCLOC) 3483 (96.22%) | ||
| Logical Lines of Code (LLOC) 1194 (32.98%) | ||
| Classes 1115 (93.38%) | ||
| Average Class Length 17 | ||
| Average Method Length 3 | ||
| Functions 79 (6.62%) | ||
| Average Function Length 6 | ||
| Not in classes or functions 0 (0.00%) | ||
|
|
||
| Complexity | ||
| Cyclomatic Complexity / LLOC 0.51 | ||
| Cyclomatic Complexity / Number of Methods 2.72 | ||
|
|
||
| Data Source Analysed | ||
|
|
||
| Directories 20 | ||
| Files 72 | ||
|
|
||
| Size | ||
| Lines of Code (LOC) 3721 | ||
| Comment Lines of Code (CLOC) 136 (3.65%) | ||
| Non-Comment Lines of Code (NCLOC) 3585 (96.35%) | ||
| Logical Lines of Code (LLOC) 1196 (32.14%) | ||
| Classes 1116 (93.31%) | ||
| Average Class Length 17 | ||
| Average Method Length 3 | ||
| Functions 80 (6.69%) | ||
| Average Function Length 6 | ||
| Not in classes or functions 0 (0.00%) | ||
|
|
||
| Complexity | ||
| Cyclomatic Complexity / LLOC 0.55 | ||
| Cyclomatic Complexity / Number of Methods 2.88 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php | ||
| $closure = function ($data) { | ||
| $filterOnKeys = array( | ||
| 'namespaces', | ||
| 'interfaces', | ||
| 'traits', | ||
| 'classes', 'abstractClasses', 'concreteClasses', | ||
| 'functions', 'namedFunctions', 'anonymousFunctions', | ||
| 'classConstants', 'globalConstants', 'magicConstants', | ||
| ); | ||
|
|
||
| foreach ($data as $title => &$keys) { | ||
| if (strpos($title, 'StructureAnalyser') === false) { | ||
| continue; | ||
| } | ||
| // looking into Structure Analyser metrics only | ||
| foreach ($keys as $key => $val) { | ||
| if (!in_array($key, $filterOnKeys)) { | ||
| unset($keys[$key]); // "removed" unsolicited values | ||
| continue; | ||
| } | ||
| } | ||
| } | ||
| return $data; | ||
| }; | ||
|
|
||
| return $closure; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| :revdate: 2015-04-16 | ||
| :revnumber: 3.0.1 | ||
| :revdate: 2015-05-11 | ||
| :revnumber: 3.1.0 | ||
| :deprecated: 2.6.3 | ||
| :deprecatedPubDate: April 15, 2015 | ||
| :stable: 3.0.1 | ||
| :stablePubDate: April 16, 2015 | ||
| :stable: 3.1.0 | ||
| :stablePubDate: May 11, 2015 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,31 @@ | ||
|
|
||
| Data Source Analysed | ||
|
|
||
| Directories 20 | ||
| Files 73 | ||
|
|
||
| Structure | ||
| Namespaces 20 | ||
| Interfaces 8 | ||
| Traits 0 | ||
| Classes 65 | ||
| Abstract Classes 6 (9.23%) | ||
| Concrete Classes 59 (90.77%) | ||
| Methods 295 | ||
| Scope | ||
| Non-Static Methods 282 (95.59%) | ||
| Static Methods 13 (4.41%) | ||
| Visibility | ||
| Public Method 251 (85.08%) | ||
| Protected Method 34 (11.53%) | ||
| Private Method 10 (3.39%) | ||
| Functions 12 | ||
| Named Functions 0 (0.00%) | ||
| Anonymous Functions 12 (100.00%) | ||
| Constants 22 | ||
| Global Constants 0 (0.00%) | ||
| Magic Constants 3 (13.64%) | ||
| Class Constants 19 (86.36%) | ||
| Tests | ||
| Classes 0 | ||
| Methods 0 | ||
|
|
||
| Data Source Analysed | ||
|
|
||
| Directories 20 | ||
| Files 72 | ||
|
|
||
| Structure | ||
| Namespaces 20 | ||
| Interfaces 8 | ||
| Traits 0 | ||
| Classes 64 | ||
| Abstract Classes 6 (9.38%) | ||
| Concrete Classes 58 (90.62%) | ||
| Methods 293 | ||
| Scope | ||
| Non-Static Methods 280 (95.56%) | ||
| Static Methods 13 (4.44%) | ||
| Visibility | ||
| Public Method 250 (85.32%) | ||
| Protected Method 34 (11.60%) | ||
| Private Method 9 (3.07%) | ||
| Functions 13 | ||
| Named Functions 0 (0.00%) | ||
| Anonymous Functions 13 (100.00%) | ||
| Constants 22 | ||
| Global Constants 0 (0.00%) | ||
| Magic Constants 3 (13.64%) | ||
| Class Constants 19 (86.36%) | ||
| Tests | ||
| Classes 0 | ||
| Methods 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
|
|
||
| Data Source Analysed | ||
|
|
||
| Directories 20 | ||
| Files 72 | ||
|
|
||
| Structure | ||
| Namespaces 20 | ||
| Interfaces 8 | ||
| Traits 0 | ||
| Classes 64 | ||
| Abstract Classes 6 (9.38%) | ||
| Concrete Classes 58 (90.62%) | ||
| Functions 13 | ||
| Named Functions 0 (0.00%) | ||
| Anonymous Functions 13 (100.00%) | ||
| Constants 22 | ||
| Global Constants 0 (0.00%) | ||
| Magic Constants 3 (13.64%) | ||
| Class Constants 19 (86.36%) |
Oops, something went wrong.
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this on the 3.0 branch?
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I've in mind to merge source code in master branch but only at the end of this year. Due to LTS for 2.6 that end in December 2015
And I don't think it really necessary to create a new branch for major version 3.x
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrahamCampbell I'll probably not wait end of this year and put major 3.x code on master branch.
But to keep LTS, I'll create a branch 2.6 for legacy code
No date planned for this operation.
BTW, php-reflect 3 is not suppose to evoluate as v2, due to its new architecture. And php-compatinfo may be evolved without php-reflect (or almost)
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing this to a branch called 3.0 means that people using
3.0.*@devare actually getting 3.1 code...a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surely wrong.
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3.0 branch should be renamed to 3.1.
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, probably. Naming it 3.0 was a bad idea at origin, but I don't think at least to reached the 3.1 before end of LTS for 2.6 ;-)
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 is compatible with 3.1 (that will add a filter feature: more details will come soon on the blog project)
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't matter at all. You are literally saying that 3.1 is 3.0, which is total rubbish.
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'll merge the 3.0 branch into master tomorrow, and removed it.
a01cee4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have the same problem with CompatInfo 4.0 branch.
Branches maintenance will be applied tomorrow (I've no time to it before)