Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default Ytdlp URL to something more tolerable #310

Closed
BluWizard10 opened this issue May 8, 2024 · 2 comments
Closed

Change the default Ytdlp URL to something more tolerable #310

BluWizard10 opened this issue May 8, 2024 · 2 comments

Comments

@BluWizard10
Copy link

BluWizard10 commented May 8, 2024

Honestly?

The default song is hard to listen to, it's just a weird autotuned song that isn't even something one could dance to.

I really think it's time for a change, by using a song that not only hits on all Audio Bands, but is something that is easy to listen and dance to.

The AudioLink V2 World has one that would make a suitable candidate in my opinion. It's non-copyrighted and hits on all Audio Bands. It's something that I think anyone can listen to, more so than the current default song in Ytdlp Player.

Either way, let's start a discussion on this. I'm eager to see better candidates as a new default soundtrack for the Ytdlp Player.

@float3
Copy link
Collaborator

float3 commented May 8, 2024

the default ytdlp song doesn't need to be good to dance to
personally I don't think your, mine or any other singular persons subjective opinion about the song/piece quality doesn't really matter as long as it fulfills our technical requirements:

it's possible that this list is overzealous and we should use special testing tracks for some of the less common usecases, like the last 2

  • must be hosted on YouTube, SoundCloud or similar
  • must have compatible license (example: Creative Commons Attribution-NonCommercial)
  • must allow for testing of full range (bass to highs)
  • must allow for testing different dynamics (for auto gain, and general dynamics)
  • sections with clear harmony and simple melodies, sections with complex harmony and melody
  • in the future if we want to implement beat detection it would be good to have changing tempos throughout the piece

@pema99
Copy link
Collaborator

pema99 commented May 8, 2024

We've changed to default song to Shibuya by Rollthered, which they have licensed to use under creative commons.

@pema99 pema99 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants