Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Links Populate as localhost:port #14

Open
x86txt opened this issue Nov 18, 2023 · 7 comments · Fixed by #34
Open

All Links Populate as localhost:port #14

x86txt opened this issue Nov 18, 2023 · 7 comments · Fixed by #34
Assignees
Labels
implemented Improvements or additions to documentation

Comments

@x86txt
Copy link

x86txt commented Nov 18, 2023

Hi, found your project via Reddit, very neat.

One issue is that on the dashboard, all the container links populate as http://localhost:portNumber, for example portainer is http://localhost:8000, tautulli is http://localhost:8181.

@lllllllillllllillll lllllllillllllillll self-assigned this Nov 18, 2023
@lllllllillllllillll
Copy link
Owner

Hiya,

Right now the "http://localhost:" portion is static, and for the port number I'm just grabbing the containers first exposed port.
This was kind of a quick and simple way to have the links work with already existing docker containers.

How did you want it changed?
Server IP instead of localhost, or were you wanting the option to set the link to something else?

the code can be found in /components/dashCard.js

@JonnySiHI
Copy link

Fantastic project! Server IP instead of localhost please :)

@lllllllillllllillll
Copy link
Owner

@JonnySiHI Fixed in dev branch. To be included in v0.08.

@lllllllillllllillll lllllllillllllillll linked a pull request Dec 15, 2023 that will close this issue
@lllllllillllllillll
Copy link
Owner

Links now use server IP instead of localhost in v0.08.

@lllllllillllllillll
Copy link
Owner

I ended up reverting this back to 'localhost' while working on the newer builds and haven't fixed it yet.
Reopening.

@bcurran3
Copy link

bcurran3 commented Jun 3, 2024

How did you want it changed? Server IP instead of localhost, or were you wanting the option to set the link to something else?

Default to the server IP with edit as an option. That way FQDN's can be plugged in when behind a reverse proxy. Would be super nice if you put checking labels for other info on the roadmap; i.e. traefik.http.routers.dweebui.rule to get dweebui.domain.tld to use for the link when available. You could check for watchtower labels and a slew of other things too - will keep you busy... ha ha. :-)

Project looks BEAUTIFUL. I'll continue to watch and hope to use soon.

@lllllllillllllillll
Copy link
Owner

@bcurran3

Custom links are an option within the Settings page now (v0.70-dev).
Commit: 926218e

@lllllllillllllillll lllllllillllllillll added implemented Improvements or additions to documentation and removed In-progress labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants