-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propmts Queue #1773
base: main
Are you sure you want to change the base?
Propmts Queue #1773
Conversation
Thank you very much (again) for your participation and collaboration in Fooocus, much appreciated 👍 ongoing discussion: see #1664 (comment) and below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1664 (comment) to make the code compatible for simultaneous use of multiple users. I can provide code optimisations tomorrow.
I have tried setting it, and running it, it works fine on the frontend, I am able to add prompts to queue, however, the generation does not work:
|
@LordMilutin works for me. Please check that when resolving merge conflicts the appropriate parameter count is returned in modules/advanced_parameters.py (adjust counter accordingly). @docppp Here are even more reasons why this queue needs to be well thought out:
I'd propose to mark this PR as draft, as it is not ready to be merged and might need to undergo an in-depth feasibility analysis. |
I have tested it, and it works perfectly for my issue. Great job! |
good points, I will try to analyze the code more and see if I can come up with any feasible solution. but I will focus solely on single-user scenario as this is mine field of interest (also Gradio not being good at parallel usage may even be blocker for production-ready multi-user queue). |
Thanks! |
@docppp one thing to consider, I tried queuing last night 50 queues with 32 images each, and after the 2nd or 3rd queue it stops generating. After refreshing the page and queuing again it works for a few queues and then stops. |
@LordMilutin please check it out, with new fix, I am able to generate over 250 images and it keeps going. |
@docppp hello! Sry for bothering you again, but can you add txt prompt reader in queue? So u can add 1 txt file with prompts on each line and it will generate with all settings each prompt per line |
Thanks, I was finally able to generate the whole queue last night with the update you made. Thank you so much for this! Two things to consider:
|
FINISHED_IMG.append(product[-1]) | ||
FINISHED_IMG = FINISHED_IMG[-32:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note, the max image amount per generation is configurable in the config and only defaults to 32, so this might be changed to the config rather the hardcoded number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather leave it as is, as more items in gallery may break things. It is easy to check what was generated in history log file where prompts are also shown.
@LordMilutin yup, clear button is a good idea and about point 2, see above.
@blablablazhik prompts from file is not in my plans, but you can try hardcoding it yourself (i believe i showed somewhere how to do it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather leave it as is, as more items in gallery may break things. It is easy to check what was generated in history log file where prompts are also shown. @LordMilutin yup, clear button is a good idea and about point 2, see above.
@blablablazhik prompts from file is not in my plans, but you can try hardcoding it yourself (i believe i showed somewhere how to do it).
Upon further usage, I agree that a clear queue button is a must, as well as a stop queue button. Because right now if I stop it, it will move on to another queue, and so on, so I have to stop each queue which is a lot if I have 50 queues.
Even single user would be great to start. Useful for experimenting with styles with batch gen, for example, to avoid waiting. Queue 100-1000 gens then come back in an hour or smth like that. |
Basic prompts queue that remembers all selected settings. If queue is greater than 0. button Generate will run multiple times with those options simulating" settings&prompting-generating" cycle made by hand.