Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source file renames #78

Closed
cyrush opened this issue Oct 28, 2016 · 3 comments
Closed

source file renames #78

cyrush opened this issue Oct 28, 2016 · 3 comments
Labels
task
Milestone
0.2.0

Comments

@cyrush
Copy link
Member

cyrush commented Oct 28, 2016

ex:

change:
DataType.hpp
to
conduit_data_type.hpp

This is out of an abundance of caution to avoid conflicts -- since client codes need to "include/conduit" to their include paths
@cyrush cyrush added the task label Oct 28, 2016
@cyrush cyrush added this to the 0.2.0 milestone Oct 28, 2016
@cyrush
Copy link
Member Author

cyrush commented Oct 28, 2016

also rename export headers to be .h instead of .hpp

@cyrush cyrush mentioned this issue Oct 28, 2016
Merged
@cyrush
Copy link
Member Author

cyrush commented Oct 30, 2016

will be resolved in #79

@cyrush
Copy link
Member Author

cyrush commented Nov 2, 2016

done in PR #79

@cyrush cyrush closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@cyrush