Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Node::compact() #9

Closed
cyrush opened this issue Jul 18, 2016 · 0 comments · Fixed by #11
Closed

remove Node::compact() #9

cyrush opened this issue Jul 18, 2016 · 0 comments · Fixed by #11
Labels
bug
Milestone
0.2.0

Comments

@cyrush
Copy link
Member

cyrush commented Jul 18, 2016

in favor of only compact_to()

This is to stay consistent with the types of operations we want to support as const
@cyrush cyrush added the bug label Jul 18, 2016
@cyrush cyrush added this to the 0.2.0 milestone Jul 24, 2016
cyrush added a commit that referenced this issue Jul 25, 2016
@cyrush
bugfix: remove Node::compact() compact_to()
2d392e9 
Remove non const compact() and Node returning compact_to() from Node

resolves #9 (github issue)
@cyrush cyrush mentioned this issue Jul 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

bugfix: remove Node::compact() compact_to() LLNL/conduit
1 participant
@cyrush