You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The feature example, which shows how to stop workers from within a worker leaves the stop worker command in the queue, since the worker kills itself and doesn't acknowledge that it finished. This can cause other workers later to pick this back up and kill themselves and others later on.
To Reproduce
Steps to reproduce the behavior:
merlin run feature_demo.yaml
merlin run-workers feature_demo.yaml
merlin status feature_demo.yaml
--> you'll see there's still a task in the queue
Expected behavior
The queue should be empty after the workflow finishes.
Additional context
I think the fix is to add a delay to the stop workers command in the step and background it, something like
( sleep 30; merlin stop-workers ) &
instead of just merlin stop-workers
this should fork a child background process that will execute after the parent worker finishes the step (and removes it from the server). I'm not sure what the sleep delay should be.
The text was updated successfully, but these errors were encountered:
🐛 Bug Report
Describe the bug
The feature example, which shows how to stop workers from within a worker leaves the stop worker command in the queue, since the worker kills itself and doesn't acknowledge that it finished. This can cause other workers later to pick this back up and kill themselves and others later on.
To Reproduce
Steps to reproduce the behavior:
--> you'll see there's still a task in the queue
Expected behavior
The queue should be empty after the workflow finishes.
Additional context
I think the fix is to add a delay to the stop workers command in the step and background it, something like
( sleep 30; merlin stop-workers ) &
instead of just merlin stop-workers
this should fork a child background process that will execute after the parent worker finishes the step (and removes it from the server). I'm not sure what the sleep delay should be.
The text was updated successfully, but these errors were encountered: