You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Root-finding functions like arkRootfind and cvRootfind use floating-point multiplication to check whether a sign change has occurred. This is prone to floating-point underflow (e.g. (-1e-166) * 1e-166 evaluates to 0) which makes the algorithm assume that the sign change was on the wrong sub-interval.
Here's a commit fixing this issue for cvode and arkode; feel free to pull it into sundials if you find it useful. The fix may need to be ported to other packages as well.
Thanks for maintaining sundials!
The text was updated successfully, but these errors were encountered:
Root-finding functions like
arkRootfind
andcvRootfind
use floating-point multiplication to check whether a sign change has occurred. This is prone to floating-point underflow (e.g.(-1e-166) * 1e-166
evaluates to 0) which makes the algorithm assume that the sign change was on the wrong sub-interval.Here's a commit fixing this issue for cvode and arkode; feel free to pull it into sundials if you find it useful. The fix may need to be ported to other packages as well.
Thanks for maintaining sundials!
The text was updated successfully, but these errors were encountered: