Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMAKE_CXX_STANDARD not used #21

Closed
phlptp opened this issue Jan 21, 2020 · 1 comment
Closed

CMAKE_CXX_STANDARD not used #21

phlptp opened this issue Jan 21, 2020 · 1 comment

Comments

@phlptp
Copy link
Collaborator

phlptp commented Jan 21, 2020

The units library cmake code should acknowledge and use CMAKE_CXX_STANDARD if it is defined.

currently UNITS_CXX_STANDARD is used, and that should continue to be the case but there should be a path through the CMAKE_CXX_STANDARD as well
@phlptp phlptp mentioned this issue Jan 21, 2020
Merged
@phlptp phlptp closed this as completed Jan 21, 2020
@phlptp
Copy link
Collaborator Author

phlptp commented Jan 21, 2020

Seemed more appropriate to remove UNIT_CXX_STD in favor of the more standard cmake approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phlptp