Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpRGB model conversion artifact or feature? #34

Closed
YukiSakuma opened this issue Jul 6, 2016 · 4 comments
Closed

UpRGB model conversion artifact or feature? #34

YukiSakuma opened this issue Jul 6, 2016 · 4 comments

Comments

@YukiSakuma
Copy link

YukiSakuma commented Jul 6, 2016

I am using 1.1.5 to test the new RGB model of waifu2x caffe and I notice some differences between RGB and UpRGB
Test image:
09019cd4-ac7d-11e5-818d-98d769465384
(RGB)(noise)(Level1)(tta)(RGB)(scale)(x8.000000)
Looks smooth
rgb
vs
(UpRGB)(noise)(Level1)(tta)(UpRGB)(scale)(x8.000000)
uprgb
Looks like jagged lines is this an error or a feature of UpRGB?

@nagadomi
Copy link
Contributor

nagadomi commented Jul 6, 2016

That is a feature of upconv_7 models. waifu2x-caffe is not related.
It seems that upconv_7's first noise reduction result is sharper than old vgg 7 models.

@YukiSakuma
Copy link
Author

YukiSakuma commented Jul 7, 2016

I see I tried RGB noise then UpRGB magnify, the jagged lines disappeared so I wonder how UpRGB/UpPhoto is different from RGB/Photo when scaling/magnifying?
Except for the larger output size in Up model

@nagadomi
Copy link
Contributor

nagadomi commented Jul 7, 2016

model difference is:

RGB/Photo

  1. image upscaling with nearest neighbor algorithm (very simple upscaler)
  2. fixing poor upscaled image with neural networks

UpRGB/UpPhoto

  1. directly image upscaling with neural networks (end-to-end optimization)

processing details is.. Neural networks only knows 😞. I have as impression that UpRGB/UpPhoto is very sensitive to the input image/pixels. The average quality of UpRGB/UpPhoto is better than RGB/Photo but sometimes it makes weird results.

@lltcggie
Copy link
Owner

一応変換の適用ミスがないか調べてみましたが特にそういうことはなさそうだったので、このIssueは閉じます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants