[FIRRTL][ExpandWhens] Fix performance with large blocks #5293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that we do not doubly process drivers when a wire is driven in both the
then
andelse
block, so we were removing the driver from theelse
block's driver map. Since we are using MapVectors to record drivers, which is needed for deterministic error messages, deleting a single driver from theelse
block's driver map scaled linearly with the number of drivers. Instead of removing it from theelse
block's driver map, just check if it was also in thethen
block's driver map.