[FIRRTL][ExpandWhens] Fix performance with large blocks #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure that we do not doubly process drivers when a wire is driven in both the `then` and `else` block, so we were removing the driver from the `else` block's driver map. Since we are using MapVectors to record drivers, which is needed for deterministic error messages, deleting a single driver the `else` block's driver map scaled linearly with the number of drivers. Instead of removing it from the `else` block's driver map, just check if it was also in the `then` block's driver map.
youngar
force-pushed
the
firrtl-expandwhens-slow
branch
from
bc181e8
to
6f53e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that we do not doubly process drivers when a wire is driven in both the
thenandelseblock, so we were removing the driver from theelseblock's driver map. Since we are using MapVectors to record drivers, which is needed for deterministic error messages, deleting a single driver from theelseblock's driver map scaled linearly with the number of drivers. Instead of removing it from theelseblock's driver map, just check if it was also in thethenblock's driver map.