[FIRRTL] Introduce a helper ODS class for type declaration, NFC #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
changed the title
This commit adds ODS class `FIRRTLPrimitiveType` which inherits FIRRTLDialectType to reduce boilerplate. At the same type, tweak summary to make it more consistent This is a preparation commit for introducing type alias.
uenoku
force-pushed
the
dev/uenoku/introduce-helper-class
branch
from
75e9bbb
to
d91b508
Compare
|
Not sure FIRRTLPrimitiveType is a best name so I'm open to a suggestion. I alternatively considered |
dtzSiFive
approved these changes
Jun 14, 2023
uenoku
added a commit
that referenced
this pull request
Jun 15, 2023
As mentioned in https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443 and https://mlir.llvm.org/deprecation/, `x.dyn_cast<T>/x.cast<T>/x.isa<T>` are deprecated. This commit replaces cast member functions in FIRRTL dialect with `dyn_cast<T>(x)/cast<T>(x)/isa<T>(x)`. This will make it a lot easier to migrate into type alias aware type_cast. We also need to refactor tablegen files as well but it will be done in a follow-up to avoid the conflict with #5399
|
Changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds ODS class
FIRRTLPrimitiveTypewhich inherits FIRRTLDialectType to reduce boilerplate. At the same time, tweak summary to make it more consistentThis is a preparation commit for introducing type alias.