[FIRRTL] Use preferred cast style, NFC #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in https://mlir.llvm.org/deprecation/, `x.dyn_cast<T>/x.cast<T>/x.isa<T>` are deprecated. This commit replaces each of them wtih `dyn_cast<T>(x)/cast<T>(x)/isa<T>(x)`. This will make it a lot easier to migrate into type alias aware type_cast.
uenoku
force-pushed
the
dev/uenoku/change-cast-style
branch
from
3cae38f
to
9a1731f
Compare
prithayan
reviewed
Jun 14, 2023
| @@ -732,7 +732,7 @@ Attribute Visitor::convertVectorConstant(FVectorType oldType, | |||
| newElements.push_back(convertConstant(oldElementType, oldElement)); | |||
| } | |||
|
|
|||
| auto bundleType = newElementType.cast<BundleType>(); | |||
| auto bundleType = dyn_cast<BundleType>(newElementType); | |||
There was a problem hiding this comment.
was this cast to dyn_cast intentional ?
There was a problem hiding this comment.
Thanks! It seems mistake 😔
mikeurbach
reviewed
Jun 14, 2023
prithayan
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443 and https://mlir.llvm.org/deprecation/,
x.dyn_cast<T>/x.cast<T>/x.isa<T>are deprecated. This commit replaces cast member functions in FIRRTL dialect withdyn_cast<T>(x)/cast<T>(x)/isa<T>(x).This will make it a lot easier to migrate into type alias aware type_cast. We also need to refactor tablegen files as well but it will be done in a follow-up to avoid the conflict with #5399