[FIRRTL][InferWidths] Tweak debug printing to show names and more bits. #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found that 0xFFF is not enough to always produce unique strings for constraints I'm debugging, bump a bit from 4096 to 65536 for now (still keeping it short but more bits to lower chance of collision). Also add the result of `getFieldName()` to the debug printing for each variable to make it easier, especially for blockarguments, to match each to its origin.
seldridge
approved these changes
Jun 15, 2023
Good call, totally, yes. Would avoid collisions entirely and probably be more readable especially on small examples (vs whatever low bits of pointers happen to be). Will land as-is for now, but that would be better. Future work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that 0xFFF is not enough to always produce unique strings for constraints I'm debugging, bump a bit from 4096 to 65536 for now (still keeping it short but more bits to lower chance of collision).
Also add the result of
getFieldName()to the debug printing for each variable to make it easier, especially for blockarguments, to match each to its origin.