[FIRRTL] Implement alias-aware type casts #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds minimal changes BaseTypeAliasType for base type alias. Implement storage and methods for FIRRTLBaseType and FieldIDTypeInterface. This doesn't include recursive property chagnes and `FIRRTLBaseType::getAnonnymousType` whcih requires more broader changes.
uenoku
force-pushed
the
dev/uenoku/implement-type-cast
branch
4 times, most recently
from
f4ff2d0
to
6f9cecd
Compare
This implements `type_isa/type_cast/type_dyn_cast/type_dyn_cast_or_null`. When a given type is an alias, these casts will visit its inner type recursively. These type casts can be used anywhere and if the requested type is non-base type or FIRRTLBaseType itself, then it will optimized in the compile time,
uenoku
force-pushed
the
dev/uenoku/implement-type-cast
branch
from
6f9cecd
to
9987245
Compare
uenoku
force-pushed
the
dev/uenoku/implement-type-cast
branch
from
2037106
to
bbb4acd
Compare
This was referenced Jun 22, 2023
prithayan
approved these changes
Jun 22, 2023
Co-authored-by: Prithayan Barua <prithayan@gmail.com>
uenoku
added a commit
that referenced
this pull request
Jul 19, 2023
This PR mechanically replaces type casts with `firrtl::type*` casts which strips outer most type aliases. Also replace TypeSwitch with FIRRTLTypeSwitch. Unlike #5167, this PR just replaces all the casts in FIRRTL dialect with `firrtl::type_*` because it's tedious to think about whether or not `firrtl::type_cast` is necessary. Since type casts introduced by #5417 automatically eliminate unnecessary look up for type aliases at the compile time, there is no runtime regression because of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
type_isa/type_cast/type_dyn_cast/type_dyn_cast_or_null. When a given type is an alias, these casts will visit its inner type recursively. These type casts can be used anywhere and if the requested type is non-base type or FIRRTLBaseType itself, then it will optimized in the compile time.