Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] ExtractClasses: Fix use-after-free. #5429

Merged
merged 1 commit into from
Jun 20, 2023
Merged

[FIRRTL] ExtractClasses: Fix use-after-free. #5429

merged 1 commit into from
Jun 20, 2023

Conversation

dtzSiFive
Copy link
Contributor

Fixes #5425.

This was on the module, but similarly don't erase
the IR until after removing from data-structure referring to it, as general good practice.

@dtzSiFive
[FIRRTL] ExtractClasses: Fix use-after-free.
c50f0e7 
Fixes llvm#5425.

This was on the module, but similarly don't erase
the IR until after removing from data-structure referring to it,
as general good practice.
@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label Jun 20, 2023
@dtzSiFive dtzSiFive merged commit 9517297 into llvm:main Jun 20, 2023
@dtzSiFive dtzSiFive deleted the fix/issue-5425 branch June 20, 2023 15:08
@mikeurbach
Copy link
Contributor

Oops, thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIRRTL] Nightly failing Valgrind test "extract-classes.mlir"
2 participants
@dtzSiFive @mikeurbach