Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][Properties] Add List<T>, Map<K, V> types. #5492

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[FIRRTL][Properties] Add List<T>, Map<K, V> types. #5492

merged 3 commits into from
Jun 27, 2023

Conversation

dtzSiFive
Copy link
Contributor

Add two new property-aggregate types: firrtl.list and firrtl.map.

Ops to create values of these types and parser support will follow.

mikeurbach
mikeurbach approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good implementation to me, thanks for adding this!

test/Dialect/FIRRTL/test.mlir Show resolved Hide resolved
@dtzSiFive
Test map using more complicated type.
4ff4e94 
Per reviewer suggestion, thanks!
@dtzSiFive dtzSiFive merged commit 3665b66 into llvm:main Jun 27, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/prop-agg-types branch June 27, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@rwy7 rwy7 Awaiting requested review from rwy7

@youngar youngar Awaiting requested review from youngar

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzSiFive @mikeurbach