Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMCP] Mark PlusArgs intrinsics as overdefined #5725

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jackkoenig
Copy link
Contributor

Fixes #5722

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for getting this fix in, @jackkoenig!

lib/Dialect/FIRRTL/Transforms/IMConstProp.cpp Outdated Show resolved Hide resolved
Fixes #5722

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@jackkoenig jackkoenig force-pushed the dev/jackkoenig/fix-imcp-plusargs branch from e4b8dce to fa05be8 Compare July 28, 2023 21:09
@seldridge seldridge merged commit cb8e839 into main Jul 28, 2023
5 checks passed
@jackkoenig jackkoenig deleted the dev/jackkoenig/fix-imcp-plusargs branch August 22, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIRRTL] PlusArgs Intrinsics lower to SystemVerilog with high impedance values
2 participants