[LowerXMR] iterate to handle ref.sub . #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to handle everything else in a single walk. Walking the ref dataflow directly would eliminate the need for this iteration, but finding the "roots" requires an IR walk anyway so just handle everything we can during a single walk and for any ref.sub's encountered handle them separately. The outer iteration loop is bounded by the number of ref.sub's chained through `backedges` to storage (`ref.define` to storage (ports/instance results)), which is expected to be very small in practice, at worst O(ports).
prithayan
reviewed
Jul 31, 2023
Add test for multi-iteration (not just post-walk) that fails without this fix. Per reviewer feedback, thanks!
|
Thanks, @prithayan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to handle everything else in a single walk.
Walking the ref dataflow directly would eliminate the need for this iteration, but finding the "roots" requires an IR walk anyway so just handle everything we can during a single walk and for any ref.sub's encountered handle them separately.
The outer iteration loop is bounded by the number of ref.sub's chained through
backedgesto storage (ref.defineto storage (ports/instance results)), which is expected to be very small in practice, at worst O(ports).