Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIREmitter] support property types and expressions #5740

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jul 31, 2023

This adds missing support for string and integer typed properties, as well as propassign, and constant string and integer expressions.

@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jul 31, 2023
@youngar youngar force-pushed the firemitter-bigint branch 2 times, most recently from 43b688d to 791bb06 Compare July 31, 2023 22:46
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngar youngar merged commit b4f0691 into llvm:main Jul 31, 2023
5 checks passed
@youngar youngar deleted the firemitter-bigint branch July 31, 2023 23:32
@dtzSiFive
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants