-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIRRTL] Add ObjectSubfieldOp #5768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Added some comments. A test showing it in IR and some error checks would be great 👍 .
61472f9
to
3a2da71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a nitpicky comment about the op naming / description. It is not crucial, and I think the actual implementation looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits, would be great to get some error tests for ObjectSubfieldOp verifiers.
I didn't mention it before, but I also echo the comments about adding success/failure tests for the new op. |
4d75823
to
d89e202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Might be worth adding a couple extra tests to cover some of the verifier failures.
6657c28
to
d195a71
Compare
This op indexes into objects (values of type ClassType).