[FIRRTL] Add ObjectSubfieldOp #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
reviewed
Aug 3, 2023
rwy7
force-pushed
the
classes
branch
2 times, most recently
from
61472f9
to
3a2da71
Compare
mikeurbach
approved these changes
Aug 3, 2023
youngar
approved these changes
Aug 3, 2023
|
I didn't mention it before, but I also echo the comments about adding success/failure tests for the new op. |
rwy7
force-pushed
the
classes
branch
3 times, most recently
from
4d75823
to
d89e202
Compare
mikeurbach
approved these changes
Aug 7, 2023
rwy7
force-pushed
the
classes
branch
2 times, most recently
from
6657c28
to
d195a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This op indexes into objects (values of type ClassType).