[FIRRTL] Clean up RWProbe's verifier #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
dtzSiFive
approved these changes
Aug 8, 2023
| if (targetRef.getModule() != | ||
| (*this)->getParentOfType<FModuleLike>().getModuleNameAttr()) | ||
| return emitOpError() << "has non-local target"; | ||
|
|
||
| auto target = ns.lookup(targetRef); | ||
| if (!target) | ||
| return emitOpError() << "has target that cannot be resolved: " << target; | ||
| return emitOpError() << "has target that cannot be resolved: " << targetRef; |
Merged
dtzSiFive
reviewed
Aug 8, 2023
seldridge
approved these changes
Aug 8, 2023
Comment on lines
-5129
to
-5130
| if (!targetRef) | ||
| return emitOpError("has invalid target reference"); |
There was a problem hiding this comment.
Great! Thanks for catching this.
Two changes: 1) The ODS generated verifier checks that the operation has a valid `targetRef` attribute, so there is no need to check it ourselves in the verifier. This is currently an untestable code-path. 2) When the target is invalid, it prints as `<invalid target>`. It makes more sense to print the original InnerRefAttr for this case. This change adds a test case for this.
youngar
force-pushed
the
rwprobe-verifier
branch
from
d69de22
to
8ee2d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
targetRefattribute, so there is no need to check it ourselves in the verifier. This is currently an untestable code-path.<invalid target>. It makes more sense to print the original InnerRefAttr for this case. This change adds a test case for this.