[FIRRTL][Inliner][NFC] Cleanup with some scoped state structs. #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify use and scope for all the plumbed datastructures, and perform cleanups at appropriate points automatically. Inlining methods could probably be moved to these, but use them as simple containers for now.
dtzSiFive
force-pushed
the
feature/inliner-state-structs
branch
from
82ecfdf
to
928eb74
Compare
seldridge
approved these changes
Aug 10, 2023
Comment on lines
-589
to
-595
| /// Clone and rename an operation. Return the new operation. | ||
| Operation *cloneAndRename(StringRef prefix, OpBuilder &b, IRMapping &mapper, | ||
| Operation &op, | ||
| const DenseMap<Attribute, Attribute> &symbolRenames, | ||
| const DenseSet<Attribute> &localSymbols, | ||
| ModuleNamespace &moduleNamespace, | ||
| InnerRefToNewNameMap &relocatedInnerSyms); |
There was a problem hiding this comment.
Seeing this 8-parameter (!) function get removed sure looks good.
|
Thanks for the review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group many arguments, give this a bit of structure, automatically perform fixups.