[FIRRTL][LowerToHW] Fix race by processing ports before parallel, fix failure path. #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't spawn out threads just to walk ports of each module (and the touchups done re:connections involving them), just handle this as part of existing FModuleOp -> HWModuleOp lowering. Tweak code to exit early if cause for pass failure is encountered. (previously it indicated failure but continued on)
dtzSiFive
requested review from
fabianschuiki,
mikeurbach,
prithayan and
youngar
|
In 6283c30 I switched to handling these as we visit each, commit prior just splits the current parallel processing into two phases to avoid the race (sine we weren't fully done handling ports yet). The switch is because this work appears rather light (similar to the work done in Fixup exit path when encountering error while touching the code. |
mikeurbach
approved these changes
Aug 9, 2023
|
Thanks! And yes, we do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5816 .
Lowering of operations in body is still done in parallel.
Type aliases are used by the port lowering code (
tryEliminatingConnectsToValue), but should already be populated for all ports+operations before call tolowerPortsAndMoveBody.