[FIRRTL] Add AnyRef cast operation, and insert during parsing. #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations where an object is instantiated and passed to a sink that expects any reference, we need to cast away the object's type to AnyRef type. This adds an operation to accomplish this, and inserts it when necessary in the parser.
mikeurbach
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
mikeurbach
commented
Sep 11, 2023
| if (lhsType != rhsType) { | ||
| // If the lhs is anyref, and the rhs is a ClassType, insert a cast. | ||
| if (isa<AnyRefType>(lhsType) && isa<ClassType>(rhsType)) | ||
| rhs = builder.create<ObjectAnyRefCastOp>(rhs); |
There was a problem hiding this comment.
I think this is fine to be inserted regardless of IR version, right? Both AnyRefType and ClassType parsers are guarded behind the same 3.2.0 version.
uenoku
reviewed
Sep 12, 2023
uenoku
reviewed
Sep 12, 2023
|
Thanks for the reviews @uenoku ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where an object is instantiated and passed to a sink that expects any reference, we need to cast away the object's type to AnyRef type. This adds an operation to accomplish this, and inserts it when necessary in the parser.