[FIRRTL] Check unknown width and reset rules during parsing 4.0.0. #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthscsi
reviewed
Feb 21, 2024
| if (ftype.hasUninferredWidth()) | ||
| return emitError(module.getPortLocation(idx), | ||
| "public or ext module port must have known width"); | ||
| // Presently abstract reset on extmodule is not explicitly disallowed in |
There was a problem hiding this comment.
That seems like a deficiency in the spec, not the intended behavior. I would be ok with updating the spec and enforcing this.
There was a problem hiding this comment.
There was a problem hiding this comment.
Adding the checks to the parse per current spec behavior, will extend once that is made illegal there.
Only check during parsing to stay compatibile with previous behavior. Allow abstract reset on extmodule until spec changes.
dtzSiFive
force-pushed
the
fix/public-known-types
branch
from
c10af05
to
22b7f10
Compare
dtzSiFive
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check during parsing to stay compatibile with previous behavior.
Allow abstract reset on extmodule until spec changes.