Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFCI] Declare common attributes for fmodule* #6868

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[NFCI] Declare common attributes for fmodule* #6868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 47 additions & 30 deletions include/circt/Dialect/FIRRTL/FIRRTLStructure.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,15 @@ def FModuleOp : FIRRTLModuleLike<"module", [SingleBlock, NoTerminator]> {
the module.
}];
let arguments =
(ins ConventionAttr:$convention,
ArrayRefAttr:$portLocations,
DefaultValuedAttr<AnnotationArrayAttr, "{}">:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers);
(ins ConventionAttr:$convention,
ArrayRefAttr:$portLocations,
ArrayRefAttr:$portAnnotations,
ArrayRefAttr:$portSyms,
ArrayRefAttr:$portNames,
ArrayRefAttr:$portTypes,
DefaultValuedAttr<AnnotationArrayAttr, "{}">:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers
);

let results = (outs);
let regions = (region SizedRegion<1>:$body);
Expand Down Expand Up @@ -185,16 +190,19 @@ def FExtModuleOp : FIRRTLModuleLike<"extmodule"> {
into the external module, to be used for generating XMRs. Each RefType
port must be removed by LowerXMR pass.
}];
let arguments = (ins
OptionalAttr<StrAttr>:$defname,
ConventionAttr:$convention,
ArrayRefAttr:$portLocations,
ParamDeclArrayAttr:$parameters,
DefaultValuedAttr<
AnnotationArrayAttr, "{}">:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers,
OptionalAttr<InternalPathArrayAttr>:$internalPaths
);
let arguments =
(ins OptionalAttr<StrAttr>:$defname,
ParamDeclArrayAttr:$parameters,
ConventionAttr:$convention,
ArrayRefAttr:$portLocations,
ArrayRefAttr:$portAnnotations,
ArrayRefAttr:$portSyms,
ArrayRefAttr:$portNames,
ArrayRefAttr:$portTypes,
DefaultValuedAttr<AnnotationArrayAttr, "{}">:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers,
OptionalAttr<InternalPathArrayAttr>:$internalPaths
);
let results = (outs);
let regions = (region AnyRegion:$body);

Expand Down Expand Up @@ -224,15 +232,18 @@ def FIntModuleOp : FIRRTLModuleLike<"intmodule"> {
let description = [{
The "firrtl.intmodule" operation represents a compiler intrinsic.
}];
let arguments = (ins
StrAttr:$intrinsic,
ArrayRefAttr:$portLocations,
ParamDeclArrayAttr:$parameters,
DefaultValuedAttr<AnnotationArrayAttr,
"ArrayAttr()">:$annotations,
OptionalAttr<InternalPathArrayAttr>:$internalPaths,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers
);
let arguments =
(ins StrAttr:$intrinsic,
ParamDeclArrayAttr:$parameters,
ArrayRefAttr:$portLocations,
ArrayRefAttr:$portAnnotations,
ArrayRefAttr:$portSyms,
ArrayRefAttr:$portNames,
ArrayRefAttr:$portTypes,
DefaultValuedAttr<AnnotationArrayAttr, "ArrayAttr()">:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers,
OptionalAttr<InternalPathArrayAttr>:$internalPaths
);
let results = (outs);
let regions = (region AnyRegion:$body);

Expand Down Expand Up @@ -267,13 +278,19 @@ def FMemModuleOp : FIRRTLModuleLike<"memmodule"> {
are not directly lowered to registers by the compiler.
}];
let arguments =
(ins UI32Attr:$numReadPorts, UI32Attr:$numWritePorts,
UI32Attr:$numReadWritePorts, UI32Attr:$dataWidth, UI32Attr:$maskBits,
UI32Attr:$readLatency, UI32Attr:$writeLatency, UI64Attr:$depth,
ArrayAttr:$extraPorts,
ArrayRefAttr:$portLocations,
AnnotationArrayAttr:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers);
(ins UI32Attr:$numReadPorts, UI32Attr:$numWritePorts,
UI32Attr:$numReadWritePorts, UI32Attr:$dataWidth, UI32Attr:$maskBits,
UI32Attr:$readLatency, UI32Attr:$writeLatency, UI64Attr:$depth,
ArrayAttr:$extraPorts,
ArrayRefAttr:$portLocations,
ArrayRefAttr:$portAnnotations,
ArrayRefAttr:$portSyms,
ArrayRefAttr:$portNames,
ArrayRefAttr:$portTypes,
AnnotationArrayAttr:$annotations,
DefaultValuedAttr<LayerArrayAttr, "{}">:$layers
);

let results = (outs);
let regions = (region AnyRegion:$body);

Expand Down
Loading