Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFCI] Declare common attributes for fmodule* #6868

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[NFCI] Declare common attributes for fmodule* #6868

merged 1 commit into from
Mar 25, 2024

Conversation

darthscsi
Copy link
Contributor

No description provided.

fabianschuiki
fabianschuiki approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darthscsi darthscsi merged commit 43e6f07 into main Mar 25, 2024
4 checks passed
@darthscsi darthscsi deleted the dev/darthscsi/fmod_attrs branch April 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darthscsi @fabianschuiki