Update annotation handling to fix partial field reset behavior #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adkian-sifive
requested review from
dtzSiFive,
darthscsi and
seldridge
as code owners
adkian-sifive
requested review from
fabianschuiki,
seldridge,
jackkoenig and
darthscsi
and removed request for
seldridge,
darthscsi and
dtzSiFive
adkian-sifive
force-pushed
the
adkian-sifive/fart-anno-handling
branch
from
99f51b1
to
4f91df3
Compare
seldridge
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
LGTM
A few ideas throughout.
@jackkoenig: Can you review the test case and see if there are any test cases that you have in mind that could be added?
adkian-sifive
force-pushed
the
adkian-sifive/fart-anno-handling
branch
from
10f6948
to
fa8267f
Compare
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
…6912) Update annotation handling in InferResets and SFCCompat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an initial value for a Register that includes
DontCarefor some of the fields, those fields will be excluded from the Full Async Reset Transform. WhileInferResetsandSFCCompatseparately do the right thing,InferResetsruns beforeSFCCompatand removes the FART annotation.This PR adds additional handling for the FART annotation by letting
InferResetspass through annotation