[FIRRTL] Add DPI call intrinsic and lowering pass #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/lower-dpi
branch
from
498c824
to
cbfc483
Compare
uenoku
commented
Jun 5, 2024
| @@ -59,7 +59,7 @@ def FatalOp : SimOp<"fatal"> { | |||
|
|
|||
| def DPIFuncOp : SimOp<"func.dpi", | |||
| [IsolatedFromAbove, Symbol, OpAsmOpInterface, | |||
| FunctionOpInterface, HasParent<"mlir::ModuleOp">]> { | |||
| FunctionOpInterface]> { | |||
There was a problem hiding this comment.
This is similar change to 09df7f5. It was necessary to put DPI func op into circuit op to make the lowering composable.
uenoku
commented
Jun 5, 2024
uenoku
commented
Jun 5, 2024
| | Port | Direction | Type | Description | | ||
| | ----------------- | --------- | -------- | ------------------------------- | | ||
| | clock (optional) | input | Clock | Optional clock operand | | ||
| | enable | input | UInt<1> | Enable signal | |
There was a problem hiding this comment.
enable is not optional at Chisel level to follow the same design as verification intrinsic.
dtzSiFive
reviewed
Jun 5, 2024
| FModuleOp module; | ||
| SmallVector<DPICallIntrinsicOp> dpiOps; | ||
| }; | ||
| SmallVector<DpiCallCollections> results; |
There was a problem hiding this comment.
Since we cannot know the actual number of FModuleOp beforehand I reserved 64.
There was a problem hiding this comment.
Probably 64 won't fit on the stack / small size, so maybe make the SmallVector 0-length (or 64?) or whatever seems good. Not blocking, just a stray thought since tab still open :).
| @@ -0,0 +1,54 @@ | |||
| ; RUN: firtool %s --format=fir | FileCheck %s | |||
|
|
|||
| FIRRTL version 4.0.0 | |||
There was a problem hiding this comment.
🤩 awesome seeing this end-to-end!!
dtzSiFive
approved these changes
Jun 12, 2024
uenoku
force-pushed
the
dev/hidetou/lower-dpi
branch
from
51c2761
to
02e489b
Compare
uenoku
force-pushed
the
dev/hidetou/lower-dpi
branch
from
77745c6
to
d7675f1
Compare
|
Added an error test, thank you for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DPICallIntrinsicOp and its lowering pass. DPICallIntrinsicOp is lowered into sim.func.dpi.call and sim.func.dpi ops. At FIRRTL level DPICallIntrinsicOp doesn't have symbols and instead LowerDPI pass accumulates callsites and creates symbols for dpi functions. LowerDPI pass directly lowers FIRRTL intrinsic into Sim dialect since FIRRTL doesn't have DPI/Function construct. LowerDPI pass could be simplified (or migrated into LowerToHW) once FIRRTL gets 1st class support for Function. Unrealized conversion cast is used to mix FIRRTL and HW type values before LowerToHW.