[FIRRTL] Ensure hierpath considers owning module in LowerClasses. #7272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had logic to detect if the owning module was in the middle of a hierarchical path, and build up the prefix just to the owning module in this case. However, we still used the entire original hierarchical path in the new path, which caused the prefix to the owning module to be duplicated. This is fixed by not only setting the moduleName to the owning module, but also trimming the prefix to the owning module in the original path.